From nobody Fri Dec 12 16:56:09 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4dSbFT3jnlz6Jw5w; Fri, 12 Dec 2025 16:56:13 +0000 (UTC) (envelope-from glebius@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R13" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4dSbFT2fQDz3xbP; Fri, 12 Dec 2025 16:56:13 +0000 (UTC) (envelope-from glebius@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1765558573; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=jVouLZWQkpOQ/y1UqbirnP1vQMI13WPWerwhY3wK2y4=; b=bYeALreIBp1NDBt1zGZYYMMOWViq3bLqqliJukgaS6xPdopKSL7z5GGfPMWDpVbkSlfTk1 HQ5eadBAwKac0ao9pjGpOBRq4bYg4wPkDJNf7kB2CfPTbak/LBRn5vB6mRsrM0iciILQ8z sBfcwrXrLW8VN8TBfHzKskX6LxDBDxjrmRelqaHRFB22YUq0UKbwByfWFWrZn/t9JsBcRP glIa/all5ydtfR6HtwaKuf93VobXsH3YwSDs/QSVLWA3Wm/pU9NT5RBr72jl3jcBSJi4GL MU5003cakD31LN+KO8xR/kE1+oFjWyJGo8nUFeJZ3/K7zMtdeqeKTGglCPpIkw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1765558573; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=jVouLZWQkpOQ/y1UqbirnP1vQMI13WPWerwhY3wK2y4=; b=l8oqdbbLMolEn4sjKi8WZun4GyLXmXlRH7Snx5ujGGsRkXZLEOt7zKX/CwI5VmAJmp7kGa h6qzXEwCFn42+AH+R6EmNpTjZ8WhYJUhwFHgsG6wzegDuyt+khG/uL+K/Oe+Bqk62ndnLY Rr0PU69STVMKK1Q1MhsvNGw5qBPWLiUyCFqK2ASr86gI7NHsn+YpRe+f61KddIVGl+pjxs H1gyQXpMxfpaCJFFA90gH6wx59osFDk8I7g1as/spO7fE8mLIiHDpl/qCaFYUGZcwqu1hx PyAhtxtJOuuZL3QXHwOT/uD7XhFAmrTEYlKoXUDOH8pWGnfDmq5/r3GywW/WpQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1765558573; a=rsa-sha256; cv=none; b=RPmWioOjX9wHmr/AeEsSligtZ76emexIeq4LKRm+rMppm1yUfvVi92koxa7vwxDQvpphST rP3Q/3ZkIAMXxbEy2zN/a/XaHwcJY1QBdA516bLwHhGYGYXJbi+I4AhKatNwR2VTXTRQLH ro0pYgqaehM0U88PefDwKzOWv8elBr60B/CxP38tlFFSbc/RXRk4EWQ65B4OdlHjzKa0fN 6y680vTgKJEr+UtEN3dgXmt8Uqexg20CYDL+3K1lSMCjDp6KaoND9PIvV6M8t0WBYSQj2h ZHevdCgpjNq6kvOG3Y6a78ZgcG+6k7qGpUO/FjSEYovlYiKhFfp/comTjwudFw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from cell.glebi.us (glebi.us [162.251.186.162]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: glebius) by smtp.freebsd.org (Postfix) with ESMTPSA id 4dSbFS4rzrz14Hh; Fri, 12 Dec 2025 16:56:12 +0000 (UTC) (envelope-from glebius@freebsd.org) Date: Fri, 12 Dec 2025 08:56:09 -0800 From: Gleb Smirnoff To: Ruslan Bukin Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: c52253232a78 - main - xae(4): remove unused function. Message-ID: References: <693c399d.354cb.f610b33@gitrepo.freebsd.org> List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <693c399d.354cb.f610b33@gitrepo.freebsd.org> On Fri, Dec 12, 2025 at 03:49:49PM +0000, Ruslan Bukin wrote: R> The branch main has been updated by br: R> R> URL: https://cgit.FreeBSD.org/src/commit/?id=c52253232a78dc2553d6ea7c9ab3e92301b36c01 R> R> commit c52253232a78dc2553d6ea7c9ab3e92301b36c01 R> Author: Ruslan Bukin R> AuthorDate: 2025-12-12 15:47:22 +0000 R> Commit: Ruslan Bukin R> CommitDate: 2025-12-12 15:49:37 +0000 R> R> xae(4): remove unused function. R> R> Sponsored by: CHERI Research Centre R> --- R> sys/dev/xilinx/if_xae.c | 6 ------ R> 1 file changed, 6 deletions(-) R> R> diff --git a/sys/dev/xilinx/if_xae.c b/sys/dev/xilinx/if_xae.c R> index 7880f93c48ee..435902dc3c10 100644 R> --- a/sys/dev/xilinx/if_xae.c R> +++ b/sys/dev/xilinx/if_xae.c R> @@ -543,11 +543,6 @@ xae_get_phyaddr(phandle_t node, int *phy_addr) R> return (0); R> } R> R> -static void R> -xae_qflush(if_t ifp) R> -{ R> -} R> - R> static void R> xae_stop_locked(struct xae_softc *sc) R> { R> @@ -1239,7 +1234,6 @@ xae_attach(device_t dev) R> if_setflags(ifp, IFF_BROADCAST | IFF_SIMPLEX | IFF_MULTICAST); R> if_setcapabilities(ifp, IFCAP_VLAN_MTU); R> if_setcapenable(ifp, if_getcapabilities(ifp)); R> - if_setqflushfn(ifp, xae_qflush); R> if_setioctlfn(ifp, xae_ioctl); R> if_setstartfn(ifp, xae_txstart); R> if_setinitfn(ifp, xae_init); This also means this code was never run with INVARIANTS. Otherwise it would panic in if_attach_internal(). -- Gleb Smirnoff