From owner-cvs-all  Thu Mar  7  3:22:22 2002
Delivered-To: cvs-all@freebsd.org
Received: from dragon.nuxi.com (trang.nuxi.com [66.92.13.169])
	by hub.freebsd.org (Postfix) with ESMTP
	id 91B1737B41C; Thu,  7 Mar 2002 03:22:08 -0800 (PST)
Received: (from obrien@localhost)
	by dragon.nuxi.com (8.11.6/8.11.1) id g27BM8163925;
	Thu, 7 Mar 2002 03:22:08 -0800 (PST)
	(envelope-from obrien)
Date: Thu, 7 Mar 2002 03:18:05 -0800
From: "David O'Brien" <obrien@FreeBSD.org>
To: Mike Barcroft <mike@FreeBSD.org>
Cc: Mark Murray <markm@FreeBSD.org>, cvs-committers@FreeBSD.org,
	cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/usr.bin/rwall rwall.c
Message-ID: <20020307031805.A63863@dragon.nuxi.com>
Reply-To: obrien@FreeBSD.org
References: <200203042027.g24KRc978637@freefall.freebsd.org> <20020307030244.B63484@dragon.nuxi.com> <20020307060920.C81803@espresso.q9media.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.2.5i
In-Reply-To: <20020307060920.C81803@espresso.q9media.com>; from mike@FreeBSD.org on Thu, Mar 07, 2002 at 06:09:20AM -0500
X-Operating-System: FreeBSD 5.0-CURRENT
Organization: The NUXI BSD group
X-Pgp-Rsa-Fingerprint: B7 4D 3E E9 11 39 5F A3  90 76 5D 69 58 D9 98 7A
X-Pgp-Rsa-Keyid: 1024/34F9F9D5
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
List-ID: <cvs-all.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20cvs-all>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20cvs-all>
X-Loop: FreeBSD.ORG

On Thu, Mar 07, 2002 at 06:09:20AM -0500, Mike Barcroft wrote:
> > -       if ((fd = mkstemp(tmpname)) == -1 || !(fp = fdopen(fd, "r+")))
> > +       fd = mkstemp(tmpname);
> > +       fp = fdopen(fd, "r+");
> > +       if (fd == -1 || !fp)
> > 
> > Why did you need to do such code restructuring?
> 
> This introduces a bug where fdopen() could attempt to open a bad file
> descriptor in the case of an error with mkstemp().

Exactly.  I would like all of these type of changes backed out until they
can be reviewed.  It is too easy to not realize the author's dependence
on short-circuiting.
 
-- 
-- David  (obrien@FreeBSD.org)

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message