Date: Sun, 6 Aug 2006 10:29:27 +0200 From: "Ralf S. Engelschall" <rse@FreeBSD.org> To: Dmitry Morozovsky <marck@rinet.ru> Cc: amd64@freebsd.org, rse@freebsd.org, current@freebsd.org Subject: Re: [head tinderbox] failure on amd64/amd64 Message-ID: <20060806082927.GA17297@engelschall.com> In-Reply-To: <20060805223658.X9314@woozle.rinet.ru> References: <20060805155548.EBE837302F@freebsd-current.sentex.ca> <20060805220746.U9314@woozle.rinet.ru> <20060805223658.X9314@woozle.rinet.ru>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, Aug 05, 2006, Dmitry Morozovsky wrote:
> On Sat, 5 Aug 2006, Dmitry Morozovsky wrote:
>
> DM> FT> mkdep -f .depend -a -DRDUMP -DRESCUE /src/sbin/dump/itime.c /src/sbin/dump/main.c /src/sbin/dump/optr.c /src/sbin/dump/dumprmt.c /src/sbin/dump/tape.c /src/sbin/dump/traverse.c /src/sbin/dump/unctime.c /src/sbin/dump/cache.c
> DM> FT> echo dump: /obj/amd64/src/tmp/usr/lib/libc.a >> .depend
> DM> FT> cc -O2 -pipe -DRDUMP -DRESCUE -Wsystem-headers -Werror -Wall -Wno-format-y2k -Wno-uninitialized -c /src/sbin/dump/itime.c
> DM> FT> cc -O2 -pipe -DRDUMP -DRESCUE -Wsystem-headers -Werror -Wall -Wno-format-y2k -Wno-uninitialized -c /src/sbin/dump/main.c
> DM> FT> cc -O2 -pipe -DRDUMP -DRESCUE -Wsystem-headers -Werror -Wall -Wno-format-y2k -Wno-uninitialized -c /src/sbin/dump/optr.c
> DM> FT> /src/sbin/dump/optr.c: In function `timeest':
> DM> FT> /src/sbin/dump/optr.c:214: warning: field precision is not type int (arg 7)
> DM>
> DM> It seems at least on amd64 size_t (strlen() result) is not int.
> DM>
> DM> Maybe the following quick fix?
>
> Or, maybe, the following would be less ugly:
>
> Index: optr.c
> ===================================================================
> RCS file: /home/ncvs/src/sbin/dump/optr.c,v
> retrieving revision 1.33
> diff -u -r1.33 optr.c
> --- optr.c 5 Aug 2006 12:50:38 -0000 1.33
> +++ optr.c 5 Aug 2006 18:38:21 -0000
> @@ -209,14 +209,15 @@
> mins = (deltat % 3600) / 60;
>
> tdone_str = ctime(&tdone);
> + tdone_str[(strlen(tdone_str) - 1)] = '\0';
> setproctitle(
> - "%s: pass %d: %3.2f%% done, finished in %d:%02d at %.*s",
> - disk, passno, percent, hours, mins, strlen(tdone_str) - 1, tdone_str);
> + "%s: pass %d: %3.2f%% done, finished in %d:%02d at %s",
> + disk, passno, percent, hours, mins, tdone_str);
> if (tnow >= tschedule) {
> tschedule = tnow + 300;
> if (blockswritten < 500)
> return;
> - msg("%3.2f%% done, finished in %d:%02d at %s", percent,
> + msg("%3.2f%% done, finished in %d:%02d at %s\n", percent,
> hours, mins, tdone_str);
> }
> }
Yes, that's ok. Please commit this fix for us. Thanks!
--
rse@FreeBSD.org Ralf S. Engelschall
FreeBSD.org/~rse rse@engelschall.com
FreeBSD committer www.engelschall.com
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20060806082927.GA17297>