From owner-svn-src-head@freebsd.org Wed Nov 21 22:24:30 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id E37A011488E6; Wed, 21 Nov 2018 22:24:29 +0000 (UTC) (envelope-from mpp302@gmail.com) Received: from mail-qt1-f177.google.com (mail-qt1-f177.google.com [209.85.160.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 510067A5E1; Wed, 21 Nov 2018 22:24:29 +0000 (UTC) (envelope-from mpp302@gmail.com) Received: by mail-qt1-f177.google.com with SMTP id n21so5575439qtl.6; Wed, 21 Nov 2018 14:24:29 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=vKpVHfi7WyOZMzZZC+hD9zpLkeJqGsX9AWp9YLc0kms=; b=FUUaMZEx4HogfErfIyie+V4HmO6D3KNw4p8vkLzMIgSABFFUQ3CtyLoA/bRrdVC8Io UH/UTQbeT+XPYN5iOPkPdgauz/xq1wfcsGAQvszJs/8rMtjj8+TEyXWa2EDDtMvLLtlF i1KFXhUqkO3FhFri4zLDVAV0SZS4Ao7tbrIO52xse2eryYZPNlNIrx9z30s0Wobbr4Cr lMnebj3C+BCLdYQZ439kV56fGU1XiFdlQR0f0uRC8x0RGOHeD5a20cRf6LSGTU0HFIdc j4jmcSeb9Hnfg14J3K8svWHPCWNTYn+vE6DKDUYSa4y5wJoeU195hBdO0R3yhr5VWL6M QZTw== X-Gm-Message-State: AGRZ1gLXC8NF8G8Ief7W5zLQ1yMql3PEAB6GHm+uXVPqaAUfgAIlaxkX maXhJOHly3XCFM72bL334Jtj0H1QcgBuQA== X-Google-Smtp-Source: AFSGD/WuPPIgfaqDYa1dO9KUSD9+4UdObrMgGxhEelPFliQovNqKYIQwqV1KW/0V7AIGaDiHi2MFCw== X-Received: by 2002:ac8:1d12:: with SMTP id d18mr7427987qtl.343.1542835526791; Wed, 21 Nov 2018 13:25:26 -0800 (PST) Received: from mail-qt1-f178.google.com (mail-qt1-f178.google.com. [209.85.160.178]) by smtp.gmail.com with ESMTPSA id v32sm24332683qta.37.2018.11.21.13.25.26 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 21 Nov 2018 13:25:26 -0800 (PST) Received: by mail-qt1-f178.google.com with SMTP id v11so5444921qtc.2; Wed, 21 Nov 2018 13:25:26 -0800 (PST) X-Received: by 2002:ac8:43d0:: with SMTP id w16mr7614286qtn.78.1542835526092; Wed, 21 Nov 2018 13:25:26 -0800 (PST) MIME-Version: 1.0 References: <201811211654.wALGsAPT072769@pdx.rh.CN85.dnsmgr.net> In-Reply-To: <201811211654.wALGsAPT072769@pdx.rh.CN85.dnsmgr.net> From: Mateusz Piotrowski <0mp@freebsd.org> Date: Wed, 21 Nov 2018 22:25:13 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r340722 - head/lib/libbe To: rgrimes@freebsd.org Cc: kevans@freebsd.org, svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org X-Rspamd-Queue-Id: 510067A5E1 X-Spamd-Result: default: False [-3.98 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-0.998,0]; FROM_HAS_DN(0.00)[]; R_SPF_ALLOW(-0.20)[+ip4:209.85.128.0/17]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; TO_DN_NONE(0.00)[]; DMARC_NA(0.00)[freebsd.org]; RCPT_COUNT_FIVE(0.00)[5]; NEURAL_HAM_LONG(-1.00)[-0.998,0]; RCVD_COUNT_THREE(0.00)[4]; RCVD_TLS_LAST(0.00)[]; MX_GOOD(-0.01)[cached: alt3.gmail-smtp-in.l.google.com]; NEURAL_HAM_SHORT(-0.96)[-0.963,0]; RCVD_IN_DNSWL_NONE(0.00)[177.160.85.209.list.dnswl.org : 127.0.5.0]; IP_SCORE(-1.01)[ipnet: 209.85.128.0/17(-3.40), asn: 15169(-1.56), country: US(-0.09)]; FORGED_SENDER(0.30)[0mp@freebsd.org,mpp302@gmail.com]; R_DKIM_NA(0.00)[]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US]; FROM_NEQ_ENVFROM(0.00)[0mp@freebsd.org,mpp302@gmail.com] X-Rspamd-Server: mx1.freebsd.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Nov 2018 22:24:30 -0000 Hello, On Wed, 21 Nov 2018 at 17:54, Rodney W. Grimes < freebsd@pdx.rh.cn85.dnsmgr.net> wrote: > > On Wed, Nov 21, 2018 at 10:19 AM Rodney W. Grimes > > wrote: > > > > > > > Author: 0mp (ports committer) > > > > Date: Wed Nov 21 11:22:44 2018 > > > > New Revision: 340722 > > > > URL: https://svnweb.freebsd.org/changeset/base/340722 > > > > > > > > Log: > > > > libbe(3): Put each error value in separate line. > > > > > > > > As requested by a TODO in the source code. > > > > > > > > Reviewed by: bcr > > > > Approved by: krion (mentor, implicit), mat (mentor, > implicit) > > > > Differential Revision: https://reviews.freebsd.org/D18063 > > > > > > Who with a src bit approved the commit to src? > > > > > > > I do want to clarify- bcr approved it in the review (explicitly with > > "... hereby approved!") -- are you mainly pointing out that he failed > > to annotate this properly in the commit, or is doc bit approval for a > > commit to a manpage in src insufficient? > > That is defanitly a bit of a grey area, from reading and re-reading > the commit bit page it is clear that a doc committer can commit > to src documentation, it is not clear if they can approve a commit > by someone else to the src tree, it does say > ""Approved by" from a non-mentored committer > with the appropriate bit" > > It probably would be fine to have said Approved by: bcr. > True. Perhaps as a ports committer I should even write "Approved by: bcr (doc)" to make it clear that I collected appropriate approvals before committing. I've been committing small patches to the src tree for a couple of months now and I've heard that "Reviewed by: bcr" is sufficient. I guess that now I understand that "Reviewed by" is for listing people and teams who reviewed the code and "Approved by" is for listing all the necessary approvals one has to collect in order to commit. I still question what a out of scope commit that is > approved by: (mentor, implicit). I am not even sure > what that means in this context. Have his mentors > said he can commit anything anyplace without them > seeing it? If so then release the mentor/mentee bit > would be more appropriate? > mat@ and krion@ told me that I don't have to ask them about explicit approval before committing to doc or src. If I gather all the necessary approvals from doc and src committers then I am able to commit with an implicit approval from my mentors. > > As an aside, happy to approve any changes to these manpages as the > > current bectl/libbe maintainer for anyone that wants to improve them. > > =) > I'm really sorry, this is my fault. Usually, I request people, who recently contributed to a certain part of a tree or who are listed in the MAINTAINERS file, to review my changes. This time it was only meant to be a small improvement to our documentation without any actual content changes to the manual page itself so I only notified bcr. Regards, Mateusz