From owner-cvs-all  Sat Aug  5  8:32:41 2000
Delivered-To: cvs-all@freebsd.org
Received: from itesec.hsc.fr (itesec.hsc.fr [192.70.106.33])
	by hub.freebsd.org (Postfix) with ESMTP
	id 5845F37B9CC; Sat,  5 Aug 2000 08:32:36 -0700 (PDT)
	(envelope-from Alain.Thivillon@hsc.fr)
Received: from yoko.hsc.fr (yoko.hsc.fr [192.70.106.76])
	(using TLSv1 with cipher EDH-RSA-DES-CBC3-SHA (168/168 bits))
	(Client CN "yoko.hsc.fr", Issuer CN "HSC CA" (verified OK))
	by itesec.hsc.fr (Postfix) with ESMTP
	id 409E310E1A; Sat,  5 Aug 2000 17:32:32 +0200 (CEST)
Received: by yoko.hsc.fr (Postfix-TLS, from userid 1001)
	id 126FC9B01A; Sat,  5 Aug 2000 17:32:13 +0200 (CEST)
Date: Sat, 5 Aug 2000 17:32:12 +0200
From: Alain Thivillon <Alain.Thivillon@hsc.fr>
To: Kris Kennaway <kris@FreeBSD.org>
Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sbin/ccdconfig ccdconfig.c
Message-ID: <20000805173212.A12185@yoko.hsc.fr>
References: <200008050606.XAA79437@freefall.freebsd.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
User-Agent: Mutt/1.2.2i
In-Reply-To: <200008050606.XAA79437@freefall.freebsd.org>; from kris@FreeBSD.org on Fri, Aug 04, 2000 at 11:06:49PM -0700
X-Organization: Herve Schauer Consultants
X-Operating-System: FreeBSD 5.0-CURRENT
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.ORG

Kris Kennaway <kris@FreeBSD.org> écrivait (wrote) :

> kris        2000/08/04 23:06:49 PDT
> 
>   Modified files:
>     sbin/ccdconfig       ccdconfig.c 
>   Log:
>   Don't call warnx() without a format string (localized error messages
>   could conceivably cause a crash).

This breaks world:

mkdep -f .depend -a    -I/src/5.0-CURRENT/src/sbin/ccdconfig/../../sys
-I/usr/obj/src/5.0-CURRENT/src/i386/usr/include
/src/5.0-CURRENT/src/sbin/ccdconfig/ccdconfig.c
/src/5.0-CURRENT/src/sbin/ccdconfig/ccdconfig.c:725: unterminated string
or character constant
/src/5.0-CURRENT/src/sbin/ccdconfig/ccdconfig.c:635: possible real start
of unterminated constant
mkdep: compile failed
*** Error code 1

Stop in /src/5.0-CURRENT/src/sbin/ccdconfig.
*** Error code 1

Patch:

--- src/sbin/ccdconfig/ccdconfig.c.orig Sat Aug  5 14:05:02 2000
+++ src/sbin/ccdconfig/ccdconfig.c      Sat Aug  5 17:29:50 2000
@@ -632,7 +632,7 @@
                    cip[i].ci_pathlen) != cip[i].ci_pathlen) {
                        printf("\n");
                        warnx("can't read component pathname");
-                       warnx("%s', kvm_geterr(kd));
+                       warnx("%s", kvm_geterr(kd));
                        goto done;
                }
                printf((i + 1 < cs->sc_nccdisks) ? "%s " : "%s\n", path);



To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message