From owner-freebsd-net@FreeBSD.ORG  Wed Feb  8 05:56:04 2006
Return-Path: <owner-freebsd-net@FreeBSD.ORG>
X-Original-To: freebsd-net@FreeBSD.org
Delivered-To: freebsd-net@FreeBSD.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 4EDE116A420
	for <freebsd-net@FreeBSD.org>; Wed,  8 Feb 2006 05:56:04 +0000 (GMT)
	(envelope-from gnn@neville-neil.com)
Received: from mrout3.yahoo.com (mrout3.yahoo.com [216.145.54.173])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 16A6E43D45
	for <freebsd-net@FreeBSD.org>; Wed,  8 Feb 2006 05:56:03 +0000 (GMT)
	(envelope-from gnn@neville-neil.com)
Received: from minion.local.neville-neil.com (proxy8.corp.yahoo.com
	[216.145.48.13])
	by mrout3.yahoo.com (8.13.4/8.13.4/y.out) with ESMTP id k185qLd3082535; 
	Tue, 7 Feb 2006 21:52:21 -0800 (PST)
Date: Wed, 08 Feb 2006 14:52:27 +0900
Message-ID: <m2pslyz9b8.wl%gnn@neville-neil.com>
From: gnn@FreeBSD.org
To: James Juran <James.Juran@baesystems.com>
In-Reply-To: <1139330290.13750.11.camel@juran.digitalnet.com>
References: <1139330290.13750.11.camel@juran.digitalnet.com>
User-Agent: Wanderlust/2.14.0 (Africa) SEMI/1.14.6 (Maruoka) FLIM/1.14.7
	(=?ISO-8859-4?Q?Sanj=F2?=) APEL/10.6 Emacs/22.0.50
	(powerpc-apple-darwin8.3.0) MULE/5.0 (SAKAKI)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Cc: freebsd-net@FreeBSD.org
Subject: Re: Zeroing wrong union member in in6_control()
X-BeenThere: freebsd-net@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Networking and TCP/IP with FreeBSD <freebsd-net.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-net>
List-Post: <mailto:freebsd-net@freebsd.org>
List-Help: <mailto:freebsd-net-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 08 Feb 2006 05:56:04 -0000

At Tue, 07 Feb 2006 11:38:09 -0500,
James Juran wrote:
> 
> [1  <text/plain (quoted-printable)>]
> In what looks like a copy&paste remnant from the preceding case, the
> wrong union member is used as the first argument to bzero in
> in6_control().  This doesn't cause an actual bug, but making this change
> would improve code clarity and robustness to change and also avoids a
> warning from a certain static analysis tool.
> 
> I'm not a regular FreeBSD contributor, so if this patch is worthwhile
> can someone please apply it?  If I should send things like this to a
> different mailing list in the future, please let me know.

The Kame list is still the best one for this (kame
<snap-users@kame.net>) but I've forwarded it for you.

I'll take care of getting this into FreeBSD though.

Thanks,
George