From owner-svn-src-head@FreeBSD.ORG Wed Jul 31 18:42:29 2013 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id D1B2588C for ; Wed, 31 Jul 2013 18:42:29 +0000 (UTC) (envelope-from mailer-daemon@vniz.net) Received: from mail-lb0-f182.google.com (mail-lb0-f182.google.com [209.85.217.182]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 2A4372235 for ; Wed, 31 Jul 2013 18:42:28 +0000 (UTC) Received: by mail-lb0-f182.google.com with SMTP id v20so840668lbc.41 for ; Wed, 31 Jul 2013 11:42:26 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:openpgp:content-type :content-transfer-encoding:x-gm-message-state; bh=xCLGl3BZhEUJ2+dhwzBEidLGM3Dvyuhfsl1NwyQg9wg=; b=lGj1pcwGiyQ6B+5QM+iTgyEHJGC+Mp0xk9w2qC7c3TedrbDY4NQs+7rNKQtzwuG9dt tfv24vQMUd2upYOrY1esVUP1vn1rEpwTFATDkojvtiNh9AYy4nE5T1CPgbysGAqItBiW LlvPehcapZddUuTbZYJAPl033X+OIuNcjH5mmgjYkQZce+3XA4UNLN6bTgvp4BAYyYVo 2GKp4dOD0n8oJ5rpKeT6JxnmtGCg65qAh6Aea8W7b/c49CtKvxS4XAKZxHkO6SiNCBTT a2AlEvrFtVztDdUeACHYdhd1ZBHWNf/ozcgljI12S7Nw1dkiOz8QHgw6qyxx3bY42w4K QEJg== X-Received: by 10.112.20.66 with SMTP id l2mr30500974lbe.48.1375296146728; Wed, 31 Jul 2013 11:42:26 -0700 (PDT) Received: from [192.168.1.2] ([89.169.173.68]) by mx.google.com with ESMTPSA id l10sm527646lbh.13.2013.07.31.11.42.25 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 31 Jul 2013 11:42:26 -0700 (PDT) Message-ID: <51F95A8F.1060108@freebsd.org> Date: Wed, 31 Jul 2013 22:42:23 +0400 From: Andrey Chernov User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/20130620 Thunderbird/17.0.7 MIME-Version: 1.0 To: obrien@freebsd.org Subject: Re: svn commit: r253786 - in head/sys: dev/random modules/padlock_rng modules/rdrand_rng modules/yarrow_rng References: <201307292058.r6TKwA56031193@svn.freebsd.org> <51F6E0AB.3010001@freebsd.org> <20130731000746.GA65806@dragon.NUXI.org> <51F86F53.9020600@freebsd.org> <20130731174614.GA76782@dragon.NUXI.org> In-Reply-To: <20130731174614.GA76782@dragon.NUXI.org> OpenPGP: id=964474DD Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Gm-Message-State: ALoCoQnPIHu2Od63yEDs2JgCHiHr6+bpmm3LUbU5G9778CkQ4hGFesHkiYftyskEjDuIM05a84Gc Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 31 Jul 2013 18:42:29 -0000 On 31.07.2013 21:46, David O'Brien wrote: > I realize the motivation for your r249631 change. > > But as it relates to the change I committed, there is no change in > behavior in this. If one is using a hardware RNG, yarrow is not > initialized and so the ARC4_ENTR_NONE -> ARC4_ENTR_HAVE transition > does not happen. > Uh, I never claim that it was you who makes this thing broken) I only notice that you touch this area and bring your attention that hardware RNGs should be the same way fixed for arc4 too assuming you have appropriate hardware for tests since you touch it. I don't have such hardware so ever not examine path hardware RNGs go in this case. I hope your commit backing out is not final, but will be returned after secteam@ review with this thing fixed. -- http://ache.vniz.net/ bitcoin:1G6ugdNY6e5jx1GVnAU2ntj2NEfmjKG85r