Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 2 Dec 2021 04:50:08 +0000
From:      Alexey Dokuchaev <danfe@freebsd.org>
To:        Neel Chauhan <nc@freebsd.org>
Cc:        ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org
Subject:   Re: git: 78f384660edf - main - net/astron: Unbreak build by disabling SOCI
Message-ID:  <YahQgJKX6/bcy5gq@FreeBSD.org>
In-Reply-To: <202112020446.1B24kHkm049892@gitrepo.freebsd.org>
References:  <202112020446.1B24kHkm049892@gitrepo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Dec 02, 2021 at 04:46:17AM +0000, Neel Chauhan wrote:
> commit 78f384660edf5b578487131ef8c1f30356f047e2
> 
>     net/astron: Unbreak build by disabling SOCI
> ...
> @@ -1,6 +1,6 @@
>  PORTNAME=	astron
>  PORTVERSION=	0.0.20200521
> -PORTREVISION=	1
> +PORTREVISION=	2

If the build was broken, there was no package and thus you don't need
PORTREVISION bump.

> -OPTIONS_DEFINE=		SOCI
> -OPTIONS_DEFAULT=	SOCI
> -
> -SOCI_DESC=		Database support via Soci
> -SOCI_LIB_DEPENDS=	libsoci_core.so:databases/soci
> -SOCI_CMAKE_BOOL_OFF=	CMAKE_DISABLE_FIND_PACKAGE_Soci

If the option is still valid (that is, there is support for databases/soci
in the code, just there's something wrong with it right now), it should've
been SOCI_BROKEN=<reason, e.g. error message> instead of complete option
removal.

./danfe



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?YahQgJKX6/bcy5gq>