Date: Fri, 6 Sep 1996 20:54:54 +0200 (MET DST) From: Stefan Esser <se@zpr.uni-koeln.de> To: "Rodney W. Grimes" <rgrimes@gndrsh.aac.dev.com> Cc: se@zpr.uni-koeln.de (Stefan Esser), rgrimes@freefall.freebsd.org, CVS-committers@freefall.freebsd.org, cvs-all@freefall.freebsd.org, cvs-sys@freefall.freebsd.org Subject: Re: cvs commit: src/sys/pci pcisupport.c Message-ID: <199609061854.UAA17465@x14.mi.uni-koeln.de> In-Reply-To: <199609061739.KAA13211@GndRsh.aac.dev.com> References: <199609061708.TAA16633@x14.mi.uni-koeln.de> <199609061739.KAA13211@GndRsh.aac.dev.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Rodney W. Grimes writes: > > Well, I did make sure I got that right, > > but the #if defined (Ix86_CPU) will all > > go away again, since it was an outright > > silly idea ... > > Not really a silly idea, just the implementation of how it is makes > it kinda messy, not that I have a better way to do it :-(. I'll > think on it for a while... No, my idea was to have a few KB less of kernel bloat, by only having the relevant descriptions in a custom kernel. But P5 type processors go into 486 motherboards (PODP) and 386 type processors (Cyrix 6x86) into P5 boards, and a few support chip are shared between several chip set families (the Triton II and Natoma both use the PIIX3). Some 3/4 of the definitions will go in, anyway, if the #ifdefs are CPU specific. And I'd rather not have a CPU socket (I486_SOCKET, ... :) define just to get rid of a few KB of tables. > Okay. This simplifies my next round of patches a lot, I'll wait until > after this is cleaned up. > > > I'll back those changes out, if you don't > > beat me on it (which shouldn't be too hard > > given your much better connectivity to > > Freefall :) > > If you don't get to it today, I'll probably back them out tomarrow some > time. Oh, and are you doing any more major work in there? I want to > do some reorg and major comment cleanup (I'll pass a diff by the list > first). Then I will be adding full register dump support for 439HX, > 440FX and associated functions/chips (got to figure out how to get > the USB function of the 82371SB turned on first though :-)). Regarding the pure informational output generated by pcisupport: Feel free to do whatever you want. If you are going to work on this, then I'll let you take out the #ifdefs, too, since you most probably will rearrange the different cases again. (I moved a few to group them by CPU type, but this does not seem to make too much sense any more ...) The chip set register dump code went in when I was curious about my Saturn chips configuration, since I had heard that some VGA BIOS might turn off burst mode without telling. And after I found that this doesn't happen on my system, I only left it in because I assumed other people might be as curious as I :) But I plan to radically change the PCI code based on last years experiences. Most of the special case handling can go, but Subvendor ID support has to be added (though I don't know any card that actually uses that feature, currently) and the bridge chip support has to be changed a lot. (And then there will finally be some config support for PCI, too, and ressource checking with other buses ...) I already have a concept for this, and if you intend to change the actual probe/attach, I'd like to know about your plans early ... Regards, STefan
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199609061854.UAA17465>