From owner-svn-src-head@freebsd.org Thu Jun 25 15:32:41 2020 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 967CE35D829; Thu, 25 Jun 2020 15:32:41 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: from mail-qt1-x82f.google.com (mail-qt1-x82f.google.com [IPv6:2607:f8b0:4864:20::82f]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 49t3tJ5K7xz4Cpy; Thu, 25 Jun 2020 15:32:40 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: by mail-qt1-x82f.google.com with SMTP id i16so4905327qtr.7; Thu, 25 Jun 2020 08:32:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=jTjnjjxxhD5596aFPVT5QLIw9bOLij8m1fNyH7Y5iSg=; b=IqV20Dfg7Y0A93a+vLot43jeAB0JxuOYTCrwnc/aOBxkGyCVkJExskV1nGa1tD1Z2+ g0NO8egoM4KgTtzE7Sz632UtuiWnNgoPj8zpf0Ws2mfx2jNk7RsHjYqphT9gYXNnx8wk 28NgkUQrWf/fUrrvVYgYg4fObTHB30tTYhKxUhm0pTfJnRshoezXm1fDqzDOzTc9Kq+D FSJ8iwRt9rJO2rNUvbOwhCef8h3iDUgj2wQxJscPmBNVa7Xagmvg9iUSteTg8PDeB2aQ CUmrYDGE7+SiO0uD+ZhAqvLu+L8zpJnW9n6rzz1ucjQ6T1PETDa/imuGViZPYCVDQ8Y/ SxmQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:subject:message-id :references:mime-version:content-disposition:in-reply-to; bh=jTjnjjxxhD5596aFPVT5QLIw9bOLij8m1fNyH7Y5iSg=; b=O6AwjWid811cJd487Yi/PybbuEdIs5ayCpjOCIPujVkrDX+Q654OqTrLTYgTlOWqSj kSrIGFpdLAYuVp0TZ/e2wS8myF95Bb0EfmrIJzu561vMekQ55bdXvGsU06nCEWtzw9I1 4EAkLsOzy7iEYtj0PE3vmfXL1ZQSP9Lh8eDJi2AYMoB8RuwjHNiLTyG7ICiY1bwn251P GlTP2yxlNmMg36od+45wjacSHJjkH8PG4U/ZVGxNZ+ig6QHHekN2LErPLQPI2F60HoDj rp9hbDJFCt2sdvqhSVka+9GcbXu+RSJx7UdPvDd54lLdMw9pmhbD9IJl6qsZw//ey/tn bSdQ== X-Gm-Message-State: AOAM533tMGwOenG6pX2urIw1D9vUE1N0oJnp85LuJI6e8ukFYOphg47m OVz7xzjQgvwZFAjNTiv/ex2pEGBaFldQag== X-Google-Smtp-Source: ABdhPJxwAvRpfG4/nnbFQtRMLB9CTR0EgpG+gz0pPBpg307IrvbCw5wUK8qw9TZN8Bt2ZR8HcF/EMw== X-Received: by 2002:ac8:3981:: with SMTP id v1mr29015554qte.134.1593099159481; Thu, 25 Jun 2020 08:32:39 -0700 (PDT) Received: from raichu (bras-base-toroon0560w-grc-20-184-147-206-12.dsl.bell.ca. [184.147.206.12]) by smtp.gmail.com with ESMTPSA id i14sm5369055qkl.105.2020.06.25.08.32.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Jun 2020 08:32:38 -0700 (PDT) Sender: Mark Johnston Date: Thu, 25 Jun 2020 11:32:36 -0400 From: Mark Johnston To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r362613 - in head/sys: dev/md fs/tmpfs kern vm Message-ID: <20200625153236.GB2969@raichu> References: <202006251521.05PFLMQt023000@repo.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <202006251521.05PFLMQt023000@repo.freebsd.org> X-Rspamd-Queue-Id: 49t3tJ5K7xz4Cpy X-Spamd-Bar: - Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20161025 header.b=IqV20Dfg; dmarc=none; spf=pass (mx1.freebsd.org: domain of markjdb@gmail.com designates 2607:f8b0:4864:20::82f as permitted sender) smtp.mailfrom=markjdb@gmail.com X-Spamd-Result: default: False [-1.93 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20161025]; NEURAL_HAM_MEDIUM(-0.99)[-0.995]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36:c]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; TO_DN_NONE(0.00)[]; DMARC_NA(0.00)[freebsd.org]; NEURAL_HAM_LONG(-0.97)[-0.970]; RCVD_COUNT_THREE(0.00)[3]; MID_RHS_NOT_FQDN(0.50)[]; DKIM_TRACE(0.00)[gmail.com:+]; NEURAL_HAM_SHORT(-0.26)[-0.263]; RCVD_IN_DNSWL_NONE(0.00)[2607:f8b0:4864:20::82f:from]; FORGED_SENDER(0.30)[markj@freebsd.org,markjdb@gmail.com]; RECEIVED_SPAMHAUS_PBL(0.00)[184.147.206.12:received]; MIME_TRACE(0.00)[0:+]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; FROM_NEQ_ENVFROM(0.00)[markj@freebsd.org,markjdb@gmail.com]; RCVD_TLS_ALL(0.00)[] X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 25 Jun 2020 15:32:41 -0000 On Thu, Jun 25, 2020 at 03:21:22PM +0000, Mark Johnston wrote: > Author: markj > Date: Thu Jun 25 15:21:21 2020 > New Revision: 362613 > URL: https://svnweb.freebsd.org/changeset/base/362613 > > Log: > Call swap_pager_freespace() from vm_object_page_remove(). > > All vm_object_page_remove() callers, except > linux_invalidate_mapping_pages() in the LinuxKPI, free swap space when > removing a range of pages from an object. The LinuxKPI case appears to > be an unintentional omission that could result in leaked swap blocks, so > unconditionally free swap space in vm_object_page_remove() to protect > against similar bugs in the future. > > Reviewed by: alc, kib > Tested by: pho > Sponsored by: The FreeBSD Foundation > Differential Revision: https://reviews.freebsd.org/D25329 I forgot to add an MFC tag. I intend to MFC this commit.