From owner-freebsd-usb@FreeBSD.ORG  Mon May 26 06:26:30 2014
Return-Path: <owner-freebsd-usb@FreeBSD.ORG>
Delivered-To: freebsd-usb@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 329AF353;
 Mon, 26 May 2014 06:26:30 +0000 (UTC)
Received: from mail.turbocat.net (heidi.turbocat.net [88.198.202.214])
 (using TLSv1.1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id E63C92C03;
 Mon, 26 May 2014 06:26:29 +0000 (UTC)
Received: from laptop015.home.selasky.org
 (cm-176.74.213.204.customer.telag.net [176.74.213.204])
 (using TLSv1 with cipher ECDHE-RSA-AES128-SHA (128/128 bits))
 (No client certificate requested)
 by mail.turbocat.net (Postfix) with ESMTPSA id 388AB1FE026;
 Mon, 26 May 2014 08:26:22 +0200 (CEST)
Message-ID: <5382DEB8.5020600@selasky.org>
Date: Mon, 26 May 2014 08:27:04 +0200
From: Hans Petter Selasky <hps@selasky.org>
User-Agent: Mozilla/5.0 (X11; FreeBSD amd64;
 rv:24.0) Gecko/20100101 Thunderbird/24.1.0
MIME-Version: 1.0
To: Julian Elischer <julian@freebsd.org>, 
 "Ronald F. Guilmette" <rfg@tristatelogic.com>, freebsd-usb@freebsd.org
Subject: Re: Test Results
References: <1986.1401074203@server1.tristatelogic.com>
 <5382DC2B.4040504@selasky.org> <5382DD90.3000903@freebsd.org>
In-Reply-To: <5382DD90.3000903@freebsd.org>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
X-BeenThere: freebsd-usb@freebsd.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: FreeBSD support for USB <freebsd-usb.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-usb>,
 <mailto:freebsd-usb-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-usb/>
List-Post: <mailto:freebsd-usb@freebsd.org>
List-Help: <mailto:freebsd-usb-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-usb>,
 <mailto:freebsd-usb-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 26 May 2014 06:26:30 -0000

On 05/26/14 08:22, Julian Elischer wrote:
> I've seen this pattern a bit too much.
>
>   user: I see error X
>   dev:   turn on quirk Y, disabling {lock device, queuing, syncing,
> block erase, etc.}
>
>
> Would it be possible for part of the attach code for drives, to silently
> run through a bunch of these commands and just turn off those that
> return errors? In the Old (old) SCSI code we did this in some devices,
> and in some cases there were capability descriptions in some of the
> sense pages.
>
> (though I think that was on some proprietary subdrivers).

Yes we already do that. Please send me patches/improvements for:

sys/dev/usb/usb_msctest.c

and

usb_error_t
usb_msc_auto_quirk(struct usb_device *udev, uint8_t iface_index)

--HPS