From owner-cvs-all@FreeBSD.ORG Wed Apr 30 17:43:16 2008 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id B65211065672 for ; Wed, 30 Apr 2008 17:43:16 +0000 (UTC) (envelope-from max@love2party.net) Received: from moutng.kundenserver.de (moutng.kundenserver.de [212.227.126.188]) by mx1.freebsd.org (Postfix) with ESMTP id 473C08FC26 for ; Wed, 30 Apr 2008 17:43:16 +0000 (UTC) (envelope-from max@love2party.net) Received: from vampire.homelinux.org (dslb-088-066-002-251.pools.arcor-ip.net [88.66.2.251]) by mrelayeu.kundenserver.de (node=mrelayeu8) with ESMTP (Nemesis) id 0ML31I-1JrGKo1Lws-0000xz; Wed, 30 Apr 2008 19:43:15 +0200 Received: (qmail 72455 invoked from network); 30 Apr 2008 17:41:50 -0000 Received: from myhost.laiers.local (192.168.4.151) by ns1.laiers.local with SMTP; 30 Apr 2008 17:41:50 -0000 From: Max Laier Organization: FreeBSD To: Julian Elischer Date: Wed, 30 Apr 2008 19:39:06 +0200 User-Agent: KMail/1.9.9 References: <200804292123.m3TLNLwT044155@repoman.freebsd.org> In-Reply-To: <200804292123.m3TLNLwT044155@repoman.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200804301939.06987.max@love2party.net> X-Provags-ID: V01U2FsdGVkX1+XO3HbT1v58B2eCaHc5CJfYLT1sAxAFDEe3tq /HYemIe49kdPvj6Y6JLH2SzJa2wJ6yx90Z+B6rgvW7iG2eaYmJ t26YMfIDJorR7Dng3xOGQ== Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/net if_ethersubr.c src/sys/sys mbuf.h src/sys/kern uipc_mbuf.c src/sys/conf NOTES options X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 30 Apr 2008 17:43:16 -0000 On Tuesday 29 April 2008 23:23:21 Julian Elischer wrote: > julian 2008-04-29 21:23:21 UTC > > FreeBSD src repository > > Modified files: > sys/net if_ethersubr.c > sys/sys mbuf.h > sys/kern uipc_mbuf.c > sys/conf NOTES options > Log: > Add an option (compiled out by default) > to profile outoing packets for a number of mbuf chain > related parameters > e.g. number of mbufs, wasted space. > probably will do with further work later. This breaks the build: http://tinderbox.freebsd.org/tinderbox-head-HEAD-amd64-amd64.brief 1) Use %u to print unsigned values 2) printing [u]int64_t's has been broken since the beginning. The reason is the unfortunate choice to have int64_t be a "long int" alias on platforms with a 64bit long (while they could as easily be "long long int" as on the other platforms where long is 32bit wide - this also means that "long long" is > intmax_t which is an alias for int64_t). Hence you either have to use the (ugly) PRIu64 macro, or %ju and cast to uintmax_t. This is a no-op (as long as we don't have uint128_t or the like). > Reviewed by: various > > Revision Changes Path > 1.1482 +5 -0 src/sys/conf/NOTES > 1.627 +1 -0 src/sys/conf/options > 1.178 +152 -0 src/sys/kern/uipc_mbuf.c > 1.245 +2 -0 src/sys/net/if_ethersubr.c > 1.225 +8 -0 src/sys/sys/mbuf.h -- /"\ Best regards, | mlaier@freebsd.org \ / Max Laier | ICQ #67774661 X http://pf4freebsd.love2party.net/ | mlaier@EFnet / \ ASCII Ribbon Campaign | Against HTML Mail and News