From nobody Thu Apr 13 15:30:08 2023 X-Original-To: net@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Py3Rh4fgXz45H9J for ; Thu, 13 Apr 2023 15:30:08 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Py3Rh2Xr9z3k9l for ; Thu, 13 Apr 2023 15:30:08 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1681399808; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5U6BCx0kHiPte3PTxdqgbPAlq83yPf+F/iyEhm+v9gs=; b=Vzh8ccl4N0JjdqQpJIFdXegIHxLiFZqbcUvrDWBt6HYuYxLYO4wE6msGO21BL8lYpCP5iN 01PjQYXeBxT++EoV5kKV40jd4Jq74v1mS9F4xlr1yeNP0v0V3gIC1fDObXdABQljImg+1j 4vgyW/Ulq80OT+bTGK6hsC1xf086LsqBgUIwB3EYssG5aUHnMibMMzHDxKxjaw9kK6GAxo 5nWliPai6nasgREKpaQn3FNT/5rx3WejShqkq6CyAPwxD6tw4xDf1XZ0hH9m7Z5BC9SqY8 cNWCh7c7K1w4huh7huj/KageOypi4yGfupmbwt6TLmmh8Feg9RY7s1fPQ9f/fQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1681399808; a=rsa-sha256; cv=none; b=uCq0ZO3ya1M2+4IxUKuracpzegYtgAyiD9w/4xp3sadOWlxfh1ppVdkXe7bn5ti3XlyvfW Dm4xrdJyF9FI2GI4YrBOlh/gwodVzpELRwmDbwCDAeQd/GxO0nALe4UQBBcfT68B8QLcix 44oGerT7N6RqqxHg75XGhiXCE0AoP0ULn6/x12ptZyKtdmpuFbhLevxgcdUasDFpg+nVpj XPzlFqdVMMVzzu1uxMWyYXUdpb37e2vw9zBjjpjabrY0IkH+1c2YM80Bge/isOjSCuFaPy kmyNGvyoOC0iqez4rFqiTt8SeaenNSnoI/EgAWmr83z7jG3y94kGm4ccVvqP2g== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Py3Rh1WrbznKm for ; Thu, 13 Apr 2023 15:30:08 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 33DFU8D4083255 for ; Thu, 13 Apr 2023 15:30:08 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 33DFU8fv083254 for net@FreeBSD.org; Thu, 13 Apr 2023 15:30:08 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: net@FreeBSD.org Subject: [Bug 268490] [igb] [lagg] [vlan]: Intel i210 performance severely degraded Date: Thu, 13 Apr 2023 15:30:08 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 12.4-RELEASE X-Bugzilla-Keywords: needs-qa, regression X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: duerrd561@gmail.com X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: net@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Networking and TCP/IP with FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-net List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-net@freebsd.org MIME-Version: 1.0 X-ThisMailContainsUnwantedMimeParts: N https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D268490 --- Comment #40 from Daniel Duerr --- (In reply to Kevin Bowling from comment #39) Thanks Kevin. I've run two passes on my local branch of origin/releng/12.4 = with a `git revert 1a132077c2cb500410079f9120c3f676d15f7931` to back out that la= st bad commit. In summary, the performance is still dismal in both of the following cases. My gut says the problem is in the `vlan` driver, not the `em` (igb) driver.= On other machines that had this same exact problem, I was not using lagg but I= was using vlan. Getting rid of vlan worked around this problem. Anyways, here's the log for you: ## Round 1: fix adapter -> sc [root@nfs src]# git diff diff --git a/sys/dev/e1000/if_em.c b/sys/dev/e1000/if_em.c index e3da4a2f3d20..3d80d7dc1a3b 100644 --- a/sys/dev/e1000/if_em.c +++ b/sys/dev/e1000/if_em.c @@ -2541,7 +2541,7 @@ em_reset(if_ctx_t ctx) pba =3D E1000_PBA_34K; break; default: - if (adapter->hw.mac.max_frame_size > 8192) + if (sc->hw.mac.max_frame_size > 8192) pba =3D E1000_PBA_40K; /* 40K for Rx, 24K for Tx */ else pba =3D E1000_PBA_48K; /* 48K for Rx, 16K for Tx */ [root@nfs src]# make -j `sysctl -n hw.ncpu` buildkernel KERNCONF=3DGENERIC-NODEBUG && make installkernel KERNCONF=3DGENERIC-NODEBUG [root@nfs src]# reboot [root@nfs src]# uname -a FreeBSD nfs.tidepool.cloud 12.4-RELEASE-p1 FreeBSD 12.4-RELEASE-p1 #25 releng/12.4-n235814-4f54a7f1b95c-dirty: Thu Apr 13 06:23:53 PDT 2023=20=20= =20=20 toor@nfs.tidepool.cloud:/usr/obj/usr/src/amd64.amd64/sys/GENERIC-NODEBUG a= md64 [root@nfs src]# iperf -s ------------------------------------------------------------ Server listening on TCP port 5001 TCP window size: 64.0 KByte (default) ------------------------------------------------------------ [ 1] local 172.27.6.135 port 5001 connected with 172.27.6.129 port 17974 [ 2] local 172.27.6.135 port 5001 connected with 172.27.6.129 port 49417 [ 3] local 172.27.6.135 port 5001 connected with 172.27.6.129 port 64045 ^CWaiting for server threads to complete. Interrupt again to force quit. [ ID] Interval Transfer Bandwidth [ 2] 0.00-28.43 sec 60.0 Bytes 16.9 bits/sec [ 3] 0.00-8.09 sec 60.0 Bytes 59.4 bits/sec [ 1] 0.00-52.52 sec 60.0 Bytes 9.14 bits/sec [SUM] 0.00-52.52 sec 180 Bytes 27.4 bits/sec ## Round 2: fix adapter -> sc, restore em_if_set_promisc(ctx, IFF_PROMISC) [root@nfs src]# git diff diff --git a/sys/dev/e1000/if_em.c b/sys/dev/e1000/if_em.c index e3da4a2f3d20..4a45a0f84ce8 100644 --- a/sys/dev/e1000/if_em.c +++ b/sys/dev/e1000/if_em.c @@ -1361,7 +1361,7 @@ em_if_init(if_ctx_t ctx) em_setup_vlan_hw_support(ctx); /* Don't lose promiscuous settings */ - em_if_set_promisc(ctx, if_getflags(ifp)); + em_if_set_promisc(ctx, IFF_PROMISC); e1000_clear_hw_cntrs_base_generic(&sc->hw); /* MSI-X configuration for 82574 */ @@ -2541,7 +2541,7 @@ em_reset(if_ctx_t ctx) pba =3D E1000_PBA_34K; break; default: - if (adapter->hw.mac.max_frame_size > 8192) + if (sc->hw.mac.max_frame_size > 8192) pba =3D E1000_PBA_40K; /* 40K for Rx, 24K for Tx */ else pba =3D E1000_PBA_48K; /* 48K for Rx, 16K for Tx */ [root@nfs src]# make -j `sysctl -n hw.ncpu` buildkernel KERNCONF=3DGENERIC-NODEBUG && make installkernel KERNCONF=3DGENERIC-NODEBUG [root@nfs src]# reboot [root@nfs src]# uname -a FreeBSD nfs.tidepool.cloud 12.4-RELEASE-p1 FreeBSD 12.4-RELEASE-p1 #26 releng/12.4-n235814-4f54a7f1b95c-dirty: Thu Apr 13 06:52:12 PDT 2023=20=20= =20=20 toor@nfs.tidepool.cloud:/usr/obj/usr/src/amd64.amd64/sys/GENERIC-NODEBUG a= md64 [root@nfs src]# iperf -s ------------------------------------------------------------ Server listening on TCP port 5001 TCP window size: 64.0 KByte (default) ------------------------------------------------------------ [ 1] local 172.27.6.135 port 5001 connected with 172.27.6.129 port 34226 [ 2] local 172.27.6.135 port 5001 connected with 172.27.6.129 port 42851 [ 3] local 172.27.6.135 port 5001 connected with 172.27.6.129 port 23908 recv failed: Connection reset by peer [ ID] Interval Transfer Bandwidth [ 1] 0.00-79.38 sec 60.0 Bytes 6.05 bits/sec recv failed: Connection reset by peer [ 2] 0.00-79.37 sec 60.0 Bytes 6.05 bits/sec recv failed: Connection reset by peer [ 3] 0.00-79.37 sec 60.0 Bytes 6.05 bits/sec [SUM] 0.00-122.44 sec 180 Bytes 11.8 bits/sec --=20 You are receiving this mail because: You are the assignee for the bug.=