From owner-svn-src-all@FreeBSD.ORG Mon Jul 5 01:10:23 2010 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 74DC21065678 for ; Mon, 5 Jul 2010 01:10:23 +0000 (UTC) (envelope-from dougb@FreeBSD.org) Received: from mail2.fluidhosting.com (mx21.fluidhosting.com [204.14.89.4]) by mx1.freebsd.org (Postfix) with ESMTP id D99C48FC18 for ; Mon, 5 Jul 2010 01:10:22 +0000 (UTC) Received: (qmail 13463 invoked by uid 399); 5 Jul 2010 01:10:21 -0000 Received: from localhost (HELO ?192.168.0.143?) (dougb@dougbarton.us@127.0.0.1) by localhost with ESMTPAM; 5 Jul 2010 01:10:21 -0000 X-Originating-IP: 127.0.0.1 X-Sender: dougb@dougbarton.us Date: Sun, 4 Jul 2010 18:10:19 -0700 (PDT) From: Doug Barton To: Alexander Motin In-Reply-To: <201007011851.o61IpI9r054345@svn.freebsd.org> Message-ID: References: <201007011851.o61IpI9r054345@svn.freebsd.org> User-Agent: Alpine 2.00 (BSF 1167 2008-08-23) X-message-flag: Outlook -- Not just for spreading viruses anymore! OpenPGP: id=1A1ABC84 Organization: http://SupersetSolutions.com/ MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r209634 - head/sys/x86/isa X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 05 Jul 2010 01:10:23 -0000 This commit results in a panic at boot time for me very early on. Screenshots at: http://people.freebsd.org/~dougb/panic-01.jpg http://people.freebsd.org/~dougb/panic-02.jpg http://people.freebsd.org/~dougb/panic-03.jpg Not sure if it's relevant or not, but after the trace is done I typed 'call reboot()' and it said "panic: privcheck td != curthread" This is on -current, Core 2 Duo, i386, SMP. Updating to the revision immediately before this one is fine, so I'm sure this is the change that is causing the panic. Doug On Thu, 1 Jul 2010, Alexander Motin wrote: > Author: mav > Date: Thu Jul 1 18:51:18 2010 > New Revision: 209634 > URL: http://svn.freebsd.org/changeset/base/209634 > > Log: > Rework r209456: > Instead of using fake rid (which ISA doesn't like), delete untrusted > IRQ resource and let it be recreated. > > Modified: > head/sys/x86/isa/atrtc.c > head/sys/x86/isa/clock.c > > Modified: head/sys/x86/isa/atrtc.c > ============================================================================== > --- head/sys/x86/isa/atrtc.c Thu Jul 1 17:46:12 2010 (r209633) > +++ head/sys/x86/isa/atrtc.c Thu Jul 1 18:51:18 2010 (r209634) > @@ -259,7 +259,8 @@ atrtc_attach(device_t dev) > if (!atrtcclock_disable && > (resource_int_value(device_get_name(dev), device_get_unit(dev), > "clock", &i) != 0 || i != 0)) { > - sc->intr_rid = -1; > + sc->intr_rid = 0; > + bus_delete_resource(dev, SYS_RES_IRQ, sc->intr_rid); > if (!(sc->intr_res = bus_alloc_resource(dev, SYS_RES_IRQ, > &sc->intr_rid, 8, 8, 1, RF_ACTIVE))) { > device_printf(dev,"Can't map interrupt.\n"); > > Modified: head/sys/x86/isa/clock.c > ============================================================================== > --- head/sys/x86/isa/clock.c Thu Jul 1 17:46:12 2010 (r209633) > +++ head/sys/x86/isa/clock.c Thu Jul 1 18:51:18 2010 (r209634) > @@ -535,7 +535,8 @@ attimer_attach(device_t dev) > tc_init(&sc->tc); > if (resource_int_value(device_get_name(dev), device_get_unit(dev), > "clock", &i) != 0 || i != 0) { > - sc->intr_rid = -1; > + sc->intr_rid = 0; > + bus_delete_resource(dev, SYS_RES_IRQ, sc->intr_rid); > if (!(sc->intr_res = bus_alloc_resource(dev, SYS_RES_IRQ, > &sc->intr_rid, 0, 0, 1, RF_ACTIVE))) { > device_printf(dev,"Can't map interrupt.\n"); > > -- Improve the effectiveness of your Internet presence with a domain name makeover! http://SupersetSolutions.com/ Computers are useless. They can only give you answers. -- Pablo Picasso