From owner-svn-src-head@freebsd.org Fri Mar 25 06:39:15 2016 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 05F8EADD669; Fri, 25 Mar 2016 06:39:15 +0000 (UTC) (envelope-from gnn@neville-neil.com) Received: from smtp.hungerhost.com (smtp.hungerhost.com [216.38.51.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id D631B1A59; Fri, 25 Mar 2016 06:39:14 +0000 (UTC) (envelope-from gnn@neville-neil.com) Received: from 221x114x228x194.ap221.ftth.ucom.ne.jp ([221.114.228.194]:60176 helo=[192.168.102.200]) by vps.hungerhost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.86_1) (envelope-from ) id 1ajLOq-0002hd-QS; Fri, 25 Mar 2016 02:39:13 -0400 Subject: Re: svn commit: r297225 - in head/sys: net netinet netinet6 To: Gleb Smirnoff , "George V. Neville-Neil" References: <201603240754.u2O7suvM006925@repo.freebsd.org> <20160324203117.GY2616@FreeBSD.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org From: "George V. Neville-Neil" Message-ID: <56F4DCF2.9040505@neville-neil.com> Date: Fri, 25 Mar 2016 02:38:42 -0400 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <20160324203117.GY2616@FreeBSD.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - vps.hungerhost.com X-AntiAbuse: Original Domain - freebsd.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - neville-neil.com X-Get-Message-Sender-Via: vps.hungerhost.com: authenticated_id: gnn@neville-neil.com X-Authenticated-Sender: vps.hungerhost.com: gnn@neville-neil.com X-Source: X-Source-Args: X-Source-Dir: X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 Mar 2016 06:39:15 -0000 On 03/24/16 04:31 PM, Gleb Smirnoff wrote: > On Thu, Mar 24, 2016 at 07:54:56AM +0000, George V. Neville-Neil wrote: > G> Author: gnn > G> Date: Thu Mar 24 07:54:56 2016 > G> New Revision: 297225 > G> URL: https://svnweb.freebsd.org/changeset/base/297225 > G> > G> Log: > G> FreeBSD previously provided route caching for TCP (and UDP). Re-add > G> route caching for TCP, with some improvements. In particular, invalidate > G> the route cache if a new route is added, which might be a better match. > G> The cache is automatically invalidated if the old route is deleted. > G> > G> Submitted by: Mike Karels > G> Reviewed by: gnn > G> Differential Revision: https://reviews.freebsd.org/D4306 > > I'm quite surprised to see this checked in, taking into account that the > D4306 has strong disagreement from melifaro@. > > So, now we got two aids for poor routing: TCP route caching & flowtable. > Given that melifaro@ has not responded to emails from several folks for several weeks I pushed this in so that we could a) break the tie and b) have a place to start for improvement. The status quo was unacceptable. Best, George