From owner-freebsd-sparc64@FreeBSD.ORG  Thu Feb 26 12:28:10 2004
Return-Path: <owner-freebsd-sparc64@FreeBSD.ORG>
Delivered-To: freebsd-sparc64@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id C320016A4CE
	for <freebsd-sparc64@freebsd.org>;
	Thu, 26 Feb 2004 12:28:10 -0800 (PST)
Received: from blake.polstra.com (blake.polstra.com [64.81.189.66])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 610D343D1D
	for <freebsd-sparc64@freebsd.org>;
	Thu, 26 Feb 2004 12:28:10 -0800 (PST)	(envelope-from jdp@polstra.com)
Received: from strings.polstra.com (dsl081-189-067.sea1.dsl.speakeasy.net
	[64.81.189.67])
	by blake.polstra.com (8.12.9p2/8.12.9) with ESMTP id i1QKS9tC050297;
	Thu, 26 Feb 2004 12:28:09 -0800 (PST)	(envelope-from jdp@polstra.com)
Message-ID: <XFMail.20040226122809.jdp@polstra.com>
X-Mailer: XFMail 1.5.4 on FreeBSD
X-Priority: 3 (Normal)
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
In-Reply-To: <p0602048bbc6340543ef2@[128.113.24.47]>
Date: Thu, 26 Feb 2004 12:28:09 -0800 (PST)
From: John Polstra <jdp@polstra.com>
To: Garance A Drosihn <drosih@rpi.edu>
X-Bogosity: No, tests=bogofilter, spamicity=0.438916, version=0.14.5
cc: freebsd-sparc64@freebsd.org
Subject: Re: 64btt cvsup?
X-BeenThere: freebsd-sparc64@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Porting FreeBSD to the Sparc <freebsd-sparc64.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-sparc64>,
	<mailto:freebsd-sparc64-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-sparc64>
List-Post: <mailto:freebsd-sparc64@freebsd.org>
List-Help: <mailto:freebsd-sparc64-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-sparc64>,
	<mailto:freebsd-sparc64-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 26 Feb 2004 20:28:10 -0000

On 26-Feb-2004 Garance A Drosihn wrote:
> At 9:10 PM -0800 2/25/04, Kris Kennaway wrote:
>>Ports don't usually apply patches conditionally on the version.
>>Instead, wherever possible the patch itself should contain the
>>conditionals, i.e.
>>
>>#if __FreeBSD_version >= 50210x
>>...
>>#endif
> 
> Hmm.  But this is to Modula-3 source, so how do I do that?

You can't, because Modula-3 doesn't have anything resembling #if.
That's why you need some code in the Makefile to apply the patch
conditionally based on the value of ${OSVERSION}.

However, if you are really going to stick to your plan of orphaning
all pre-64-bit-time_t sparc64 then you can just stick something like
this into the ``.elif ${ARCH} == "sparc64"'' section of the
Makefile:

    .if ${OSVERSION} < 50210x
    BROKEN=         Installed FreeBSD version is too old for ezm3
    .endif

And then you can make the patch unconditional.

John