Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 25 Apr 2000 08:04:49 +0200 (CEST)
From:      Luigi Rizzo <luigi@info.iet.unipi.it>
To:        Archie Cobbs <archie@whistle.com>
Cc:        Julian Elischer <julian@elischer.org>, pavel@alum.mit.edu, nsayer@sftw.com, luigi@FreeBSD.ORG, freebsd-net@FreeBSD.ORG
Subject:   Re: Proposal for ethernet, bridging, netgraph
Message-ID:  <200004250604.IAA18486@info.iet.unipi.it>
In-Reply-To: <200004250214.TAA30215@bubba.whistle.com> from Archie Cobbs at "Apr 24, 2000 07:14:44 pm"

next in thread | previous in thread | raw e-mail | index | archive | help
> OK, here's a patch ready for review & test.. this patch does one

i generally like the patch. As you notice:

> Most of these patches are straightforward, however a few are
> more tricky.. in particular:
> 
> 	- pci/if_de.c      (what does TULIP_HASHONLY mean exactly?)
> 	- dev/ed/if_ed.c   (contained a BRIDGE optimization)
> 	- dev/ie/if_ie.c   (contained a BPF optimization)

this is why i suggested having some way to preserve the old
ether_input() behaviour, either by definining a new function which
does the bpf/bridge stuff and then calls ether_input(), or maybe
by using some special argument to ether_input() to tell that
we want the 'new' behaviour (one which immediately comes to
mind: use eh == NULL to mean that we want the 'new' behaviour,
since the ethernet header for bridging/bpf to work needs to
be in the mbuf.)

	cheers
	luigi
-----------------------------------+-------------------------------------
  Luigi RIZZO, luigi@iet.unipi.it  . Dip. di Ing. dell'Informazione
  http://www.iet.unipi.it/~luigi/  . Universita` di Pisa
  TEL/FAX: +39-050-568.533/522     . via Diotisalvi 2, 56126 PISA (Italy)
  Mobile   +39-347-0373137
-----------------------------------+-------------------------------------


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-net" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200004250604.IAA18486>