From owner-svn-src-all@FreeBSD.ORG Wed Nov 23 07:12:26 2011 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 77F1E106566B; Wed, 23 Nov 2011 07:12:26 +0000 (UTC) (envelope-from adrian@FreeBSD.org) Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:4f8:fff6::2c]) by mx1.freebsd.org (Postfix) with ESMTP id 67E668FC1A; Wed, 23 Nov 2011 07:12:26 +0000 (UTC) Received: from svn.freebsd.org (localhost [127.0.0.1]) by svn.freebsd.org (8.14.4/8.14.4) with ESMTP id pAN7CQkC032080; Wed, 23 Nov 2011 07:12:26 GMT (envelope-from adrian@svn.freebsd.org) Received: (from adrian@localhost) by svn.freebsd.org (8.14.4/8.14.4/Submit) id pAN7CQ64032078; Wed, 23 Nov 2011 07:12:26 GMT (envelope-from adrian@svn.freebsd.org) Message-Id: <201111230712.pAN7CQ64032078@svn.freebsd.org> From: Adrian Chadd Date: Wed, 23 Nov 2011 07:12:26 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org X-SVN-Group: head MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Cc: Subject: svn commit: r227872 - head/sys/dev/ath X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Nov 2011 07:12:26 -0000 Author: adrian Date: Wed Nov 23 07:12:26 2011 New Revision: 227872 URL: http://svn.freebsd.org/changeset/base/227872 Log: Re-lock the ath lock after ath_reset() has been called. The calibrate callout is done with the sc lock held. This only showed up when using an older NIC (AR5212) whose radio/phy requires the rfgain adjustment. Pointy-hat-to: adrian Sponsored by: Hobnob, Inc. Modified: head/sys/dev/ath/if_ath.c Modified: head/sys/dev/ath/if_ath.c ============================================================================== --- head/sys/dev/ath/if_ath.c Wed Nov 23 05:34:01 2011 (r227871) +++ head/sys/dev/ath/if_ath.c Wed Nov 23 07:12:26 2011 (r227872) @@ -5370,6 +5370,7 @@ ath_calibrate(void *arg) sc->sc_doresetcal = AH_TRUE; ATH_UNLOCK(sc); ath_reset(ifp, ATH_RESET_NOLOSS); + ATH_LOCK(sc); return; } /*