Date: Thu, 5 Apr 2018 21:29:40 -0400 From: Allan Jude <allanjude@freebsd.org> To: cem@freebsd.org Cc: src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r332070 - in head/sys/geom: . label raid Message-ID: <bf72fc9c-c3a7-da5c-d295-c28d16241209@freebsd.org> In-Reply-To: <CAG6CVpXjmyZ-gfJh%2BvkzsOQOyu8k5sxL_RgzX4k_pdRPWSuyWA@mail.gmail.com> References: <201804051356.w35Duexg022529@repo.freebsd.org> <4cd9a49c-2d75-bfac-20df-72e8c80eded4@freebsd.org> <CAG6CVpXjmyZ-gfJh%2BvkzsOQOyu8k5sxL_RgzX4k_pdRPWSuyWA@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 2018-04-05 21:20, Conrad Meyer wrote: > On Thu, Apr 5, 2018 at 6:08 PM, Allan Jude <allanjude@freebsd.org> wrote: >> On 2018-04-05 09:56, Sean Bruno wrote: >>> Author: sbruno >>> Date: Thu Apr 5 13:56:40 2018 >>> New Revision: 332070 >>> URL: https://svnweb.freebsd.org/changeset/base/332070 >>> >>> Log: >>> Squash error from geom by sizing ident strings to DISK_IDENT_SIZE. >>> >>> ... >> I might be missing something here, but it seems like you didn't actually >> change the side of >> ... >> struct md_s > > The md side can be as small as it likes. It's the caller who needs to > provide the large buffer, for other providers of the GEOM::ident > attribute. > >> And I don't see where the destination buffer went from 24 bytes to a >> larger value. > > Check the change in md_intel.c. > > Best, > Conrad > Right, but md_intel.c is for intel BIOS raid. I don't see the change that increased the size of the buffer in the caller from 24 bytes to something more useful? Or was it md_intel tasting the md(4) device? -- Allan Jude
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bf72fc9c-c3a7-da5c-d295-c28d16241209>