From owner-freebsd-multimedia@FreeBSD.ORG  Mon Dec 30 02:12:58 2013
Return-Path: <owner-freebsd-multimedia@FreeBSD.ORG>
Delivered-To: multimedia@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id EC5FFBA0;
 Mon, 30 Dec 2013 02:12:58 +0000 (UTC)
Received: from cargobay.net (cargobay.net [162.220.58.155])
 by mx1.freebsd.org (Postfix) with ESMTP id C511E1A73;
 Mon, 30 Dec 2013 02:12:58 +0000 (UTC)
Received: from [192.168.0.16] (unknown [65.35.151.3])
 by cargobay.net (Postfix) with ESMTPSA id B994B1B4B;
 Mon, 30 Dec 2013 02:03:28 +0000 (UTC)
Content-Type: text/plain;
	charset=us-ascii
Mime-Version: 1.0 (1.0)
Subject: Re: [FIXED] ports/183791: audio/liba52 (liba52-0.7.4_2) is not jobs
 safe
From: "Chad J. Milios" <milios@ccsys.com>
X-Mailer: iPhone Mail (11B554a)
In-Reply-To: <20131225130213.GA67807@gate.oper.dinoex.org>
Date: Sun, 29 Dec 2013 21:03:56 -0500
Content-Transfer-Encoding: quoted-printable
Message-Id: <39530B93-79F7-4CB2-8CA5-DAE04E08EA30@ccsys.com>
References: <20131225130213.GA67807@gate.oper.dinoex.org>
To: Peter <pmc@citylink.dinoex.sub.org>
Cc: freebsd-ports <ports@freebsd.org>,
 "multimedia@freebsd.org" <multimedia@freebsd.org>,
 "bug-followup@FreeBSD.org" <bug-followup@FreeBSD.org>
X-BeenThere: freebsd-multimedia@freebsd.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: Multimedia discussions <freebsd-multimedia.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-multimedia>, 
 <mailto:freebsd-multimedia-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-multimedia/>
List-Post: <mailto:freebsd-multimedia@freebsd.org>
List-Help: <mailto:freebsd-multimedia-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-multimedia>, 
 <mailto:freebsd-multimedia-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 30 Dec 2013 02:12:59 -0000


> On Dec 25, 2013, at 8:02 AM, Peter <pmc@citylink.dinoex.sub.org> wrote:
>=20
> This seems to be a race condition with the timestamps of the Makefiles.=20=

> "make install" thinks that the Makefiles are outdated, and recreates
> them before doing the install - but now with the target pointing directly=20=

> to /usr/local and not to the staging area.
>=20
> In the log we can see this happening:=20
>=20
>> Making install in liba52
>> gmake[1]: Entering directory `/usr/ports/audio/liba52/work/a52dec-0.7.4/l=
iba52'
>> cd .. \
>> && CONFIG_FILES=3Dliba52/Makefile CONFIG_HEADERS=3D /bin/sh ./config.stat=
us
>> config.status: creating liba52/Makefile
>> config.status: executing default-1 commands
>> gmake[1]: Leaving directory `/usr/ports/audio/liba52/work/a52dec-0.7.4/li=
ba52'
>> gmake[1]: Entering directory `/usr/ports/audio/liba52/work/a52dec-0.7.4/l=
iba52'
>> gmake[2]: Entering directory `/usr/ports/audio/liba52/work/a52dec-0.7.4/l=
iba52'
>> /bin/sh ../autotools/mkinstalldirs /usr/local/lib
>=20
> while on successful runs these lines do not appear:
>=20
>> Making install in liba52
>> gmake[1]: Entering directory `/usr/ports/audio/liba52/work/a52dec-0.7.4/l=
iba52'
>> gmake[2]: Entering directory `/usr/ports/audio/liba52/work/a52dec-0.7.4/l=
iba52'
>> /bin/sh ../autotools/mkinstalldirs /usr/ports/audio/liba52/work/stage/usr=
/local/lib
>=20
>=20
> I could not figure out why or how this happens - but for now a suitable=20=

> workaround seems to be the following addition to the (main) makefile:
>=20
>> pre-install:
>>       touch work/a52dec-*/*/Makefile

I can confirm that addition to the Makefile worked perfectly for me on all o=
f 200 runs on both test servers. Thanks Peter!

Can someone close the PR after making a commit with the addition of the afor=
ementioned pre-install target to /usr/ports/audio/liba52/Makefile please? (N=
o revision bump necessary.)

-Chad=