From owner-freebsd-numerics@freebsd.org Wed Mar 6 05:52:11 2019 Return-Path: Delivered-To: freebsd-numerics@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 23AF71529A93 for ; Wed, 6 Mar 2019 05:52:11 +0000 (UTC) (envelope-from sgk@troutmask.apl.washington.edu) Received: from troutmask.apl.washington.edu (troutmask.apl.washington.edu [128.95.76.21]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "troutmask", Issuer "troutmask" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4071B755DC for ; Wed, 6 Mar 2019 05:52:09 +0000 (UTC) (envelope-from sgk@troutmask.apl.washington.edu) Received: from troutmask.apl.washington.edu (localhost [127.0.0.1]) by troutmask.apl.washington.edu (8.15.2/8.15.2) with ESMTPS id x265q1pZ040308 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Tue, 5 Mar 2019 21:52:01 -0800 (PST) (envelope-from sgk@troutmask.apl.washington.edu) Received: (from sgk@localhost) by troutmask.apl.washington.edu (8.15.2/8.15.2/Submit) id x265q1nE040307; Tue, 5 Mar 2019 21:52:01 -0800 (PST) (envelope-from sgk) Date: Tue, 5 Mar 2019 21:52:01 -0800 From: Steve Kargl To: Bruce Evans Cc: freebsd-numerics@freebsd.org Subject: Re: Update ENTERI() macro Message-ID: <20190306055201.GA40298@troutmask.apl.washington.edu> Reply-To: sgk@troutmask.apl.washington.edu References: <20190226191825.GA68479@troutmask.apl.washington.edu> <20190227145002.P907@besplex.bde.org> <20190227074811.GA75972@troutmask.apl.washington.edu> <20190227201214.V1823@besplex.bde.org> <20190227161906.GA77785@troutmask.apl.washington.edu> <20190228060920.R4413@besplex.bde.org> <20190304212159.GA12587@troutmask.apl.washington.edu> <20190305153243.Y1349@besplex.bde.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190305153243.Y1349@besplex.bde.org> User-Agent: Mutt/1.11.2 (2019-01-07) X-Rspamd-Queue-Id: 4071B755DC X-Spamd-Bar: / Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [0.93 / 15.00]; ARC_NA(0.00)[]; HAS_REPLYTO(0.00)[sgk@troutmask.apl.washington.edu]; NEURAL_HAM_MEDIUM(-0.03)[-0.031,0]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; NEURAL_SPAM_SHORT(0.85)[0.850,0]; NEURAL_HAM_LONG(-0.62)[-0.624,0]; MIME_GOOD(-0.10)[text/plain]; RCVD_TLS_LAST(0.00)[]; DMARC_NA(0.00)[washington.edu]; AUTH_NA(1.00)[]; REPLYTO_ADDR_EQ_FROM(0.00)[]; RCVD_COUNT_THREE(0.00)[3]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_IN_DNSWL_MED(-0.20)[21.76.95.128.list.dnswl.org : 127.0.11.2]; RCPT_COUNT_TWO(0.00)[2]; MX_GOOD(-0.01)[troutmask.apl.washington.edu]; R_SPF_NA(0.00)[]; FREEMAIL_TO(0.00)[optusnet.com.au]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:73, ipnet:128.95.0.0/16, country:US]; MID_RHS_MATCH_FROM(0.00)[]; IP_SCORE(0.05)[ip: (0.10), ipnet: 128.95.0.0/16(0.15), asn: 73(0.06), country: US(-0.07)] X-BeenThere: freebsd-numerics@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Discussions of high quality implementation of libm functions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 06 Mar 2019 05:52:11 -0000 On Tue, Mar 05, 2019 at 03:48:11PM +1100, Bruce Evans wrote: > On Mon, 4 Mar 2019, Steve Kargl wrote: > > > On Thu, Feb 28, 2019 at 07:15:14AM +1100, Bruce Evans wrote: > >> ... > >> I said to use your method of __typeof(). I tested this: > >> > >> XX --- /tmp/math_private.h Sun Nov 27 17:58:57 2005 > >> XX +++ ./math_private.h Thu Feb 28 06:17:26 2019 > >> XX @@ -474,21 +474,22 @@ > >> XX /* Support switching the mode to FP_PE if necessary. */ > >> XX #if defined(__i386__) && !defined(NO_FPSETPREC) > >> XX -#define ENTERI() ENTERIT(long double) > >> XX -#define ENTERIT(returntype) \ > >> XX - returntype __retval; \ > >> XX +#define ENTERI() \ > >> XX fp_prec_t __oprec; \ > >> XX \ > >> XX if ((__oprec = fpgetprec()) != FP_PE) \ > >> XX fpsetprec(FP_PE) > >> XX -#define RETURNI(x) do { \ > >> XX - __retval = (x); \ > >> XX - if (__oprec != FP_PE) \ > >> XX - fpsetprec(__oprec); \ > >> XX +#define LEAVEI() \ > >> XX + if ((__oprec = fpgetprec()) != FP_PE) \ > >> XX + fpsetprec(FP_PE) > > > > Am I reading this diff wrong? Should LEAVEI() be > > > > #define LEAVEI() \ > > if (__oprec != FP_PE) \ > > fpsetprec(__oprec) > > > > That is, we want to reset the precision to what ENTERI > > grabbed in its conditinal expression. > > Oops. I wrote it wrong by copying the wrong clause. > > The broken version even passed quick runtime tests. This is because > the tests know that most long double functions are missing ENTERI(), > so they set the precision to FP_PE before the call. So both ENTERI() > and LEAVEI() find (__oprec = fpgetprec() equal to FP_PE and do nothing. > My math_private.h has a few additions, which meant I applied your diff manually. As I was reading it, I came across the issue. I think I have the s_cexpl.c file fixed to use LDBL_EXTRACT_WORDS instead of the new macro I introduced. I however cannot figure out what David Das did to arrive at k_exp.c, so I cannot write a similar k_cexpl.c. Yes, I added the 'c' in the name to avoid confusion in ld80/. In particular, I have no idea how he found his scaling value 'k'. Any insights? -- Steve