Date: Thu, 7 Apr 2011 17:54:40 +0400 From: Gleb Smirnoff <glebius@FreeBSD.org> To: Marko Zec <zec@FreeBSD.org> Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: svn commit: r220416 - head/sys/netgraph Message-ID: <20110407135440.GX84445@FreeBSD.org> In-Reply-To: <201104071140.p37BeAlE039248@svn.freebsd.org> References: <201104071140.p37BeAlE039248@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Apr 07, 2011 at 11:40:10AM +0000, Marko Zec wrote: M> Author: zec M> Date: Thu Apr 7 11:40:10 2011 M> New Revision: 220416 M> URL: http://svn.freebsd.org/changeset/base/220416 M> M> Log: M> Properly unref ng_hub nodes on shutdown, so that we don't leak them. M> M> MFC after: 3 days M> M> Modified: M> head/sys/netgraph/ng_hub.c M> M> Modified: head/sys/netgraph/ng_hub.c M> ============================================================================== M> --- head/sys/netgraph/ng_hub.c Thu Apr 7 11:13:50 2011 (r220415) M> +++ head/sys/netgraph/ng_hub.c Thu Apr 7 11:40:10 2011 (r220416) M> @@ -157,6 +157,8 @@ ng_hub_shutdown(node_p node) M> const priv_p priv = NG_NODE_PRIVATE(node); M> M> free(priv, M_NETGRAPH_HUB); M> + NG_NODE_SET_PRIVATE(node, NULL); M> + NG_NODE_UNREF(node); M> return (0); M> } Do we really need NG_NODE_SET_PRIVATE()? -- Totus tuus, Glebius.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20110407135440.GX84445>