From owner-freebsd-current Wed Feb 27 20:55:55 2002 Delivered-To: freebsd-current@freebsd.org Received: from elvis.mu.org (elvis.mu.org [192.203.228.196]) by hub.freebsd.org (Postfix) with ESMTP id 9074037B402 for ; Wed, 27 Feb 2002 20:55:51 -0800 (PST) Received: by elvis.mu.org (Postfix, from userid 1192) id 62B3BAE279; Wed, 27 Feb 2002 20:55:51 -0800 (PST) Date: Wed, 27 Feb 2002 20:55:51 -0800 From: Alfred Perlstein To: Peter Wemm Cc: Matthew Dillon , Julian Elischer , FreeBSD current users Subject: Re: controversial fix or some errors breaking LINT Message-ID: <20020228045551.GZ80761@elvis.mu.org> References: <20020227225459.GY80761@elvis.mu.org> <20020227231509.EB2B93809@overcee.wemm.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20020227231509.EB2B93809@overcee.wemm.org> User-Agent: Mutt/1.3.27i Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG * Peter Wemm [020227 15:44] wrote: > Alfred Perlstein wrote: > > * Matthew Dillon [020227 14:51] wrote: > > > > > > : > > > :ok so I leave it to other people to fix LINT > > > :I'm not going near it any more > > > > > > It's the responsibility of whoever added -Werror to the default > > > compile to unbreak the tree, either by fixing the problem or by > > > backing out his commit. > > > > No. Leave it in, this will benifit us all in the long run. > > > > In fact it was the _only_ way I was able to get people clean > > up bad code at a former job and I strongly support keeping > > -Weerror enabled. > > If there are files that are too hard to fix, or vendor files, or the fix > isn't clear, we should use the nowerror conf/files* flags. > > It is important that we stop new warnings turning up when the compile > output is so damn large that it hides things. > > I will do a pass over things now and see what I can do. Agreed, any doofus that obfuscates code to mask a warning gets a kick in the pants at the next BSDcon. If you don't know then ask. (I know I'll be asking Bruce/Peter if I have a problem) -- -Alfred Perlstein [alfred@freebsd.org] 'Instead of asking why a piece of software is using "1970s technology," start asking why software is ignoring 30 years of accumulated wisdom.' Tax deductible donations for FreeBSD: http://www.freebsdfoundation.org/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message