From owner-dev-commits-src-all@freebsd.org Thu Jan 28 07:51:37 2021 Return-Path: Delivered-To: dev-commits-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 28DA04FB577 for ; Thu, 28 Jan 2021 07:51:37 +0000 (UTC) (envelope-from tsoome@me.com) Received: from pv50p00im-tydg10021701.me.com (pv50p00im-tydg10021701.me.com [17.58.6.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4DRCN8721fz4lJ1 for ; Thu, 28 Jan 2021 07:51:36 +0000 (UTC) (envelope-from tsoome@me.com) Received: from nazgul.lan (148-52-235-80.sta.estpak.ee [80.235.52.148]) by pv50p00im-tydg10021701.me.com (Postfix) with ESMTPSA id 88B0C840170; Thu, 28 Jan 2021 07:51:34 +0000 (UTC) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.40.0.2.32\)) Subject: Re: git: 6e26189be406 - main - Fix loader detection of vbefb support on !amd64 From: Toomas Soome In-Reply-To: Date: Thu, 28 Jan 2021 09:51:32 +0200 Cc: John Baldwin , "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" Content-Transfer-Encoding: quoted-printable Message-Id: <2EA230CF-B642-456F-ACDA-150C016DAAAE@me.com> References: <202101272129.10RLTAee080408@gitrepo.freebsd.org> <3973a397-1250-1230-fecc-956b84c74fc9@FreeBSD.org> To: Dimitry Andric X-Mailer: Apple Mail (2.3654.40.0.2.32) X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.343, 18.0.737 definitions=2021-01-28_02:2021-01-27, 2021-01-28 signatures=0 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 mlxscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-2006250000 definitions=main-2101280038 X-Rspamd-Queue-Id: 4DRCN8721fz4lJ1 X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-BeenThere: dev-commits-src-all@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for all branches of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 28 Jan 2021 07:51:37 -0000 > On 28. Jan 2021, at 09:50, Dimitry Andric wrote: >=20 > On 28 Jan 2021, at 00:08, John Baldwin wrote: >>=20 >> On 1/27/21 1:29 PM, Dimitry Andric wrote: >>> The branch main has been updated by dim: >>> URL: = https://cgit.FreeBSD.org/src/commit/?id=3D6e26189be406a9a3799074b16925e6cd= 63cc703b >>> commit 6e26189be406a9a3799074b16925e6cd63cc703b >>> Author: Dimitry Andric >>> AuthorDate: 2021-01-27 21:28:43 +0000 >>> Commit: Dimitry Andric >>> CommitDate: 2021-01-27 21:28:43 +0000 >>> Fix loader detection of vbefb support on !amd64 >>> On i386, after 6c7a932d0b8baaaee16eca0ba061bfa6e0e57bfd, the = vbefb vt >>> driver was no longer detected by the loader, if any kernel module = was >>> loaded after the kernel itself. >>> This was caused by the parse_vt_drv_set() function being = called multiple >>> times, resetting the detection flag. (It was called multiple = times, >>> becuase i386 .ko files are shared objects like the kernel proper, = while >>> this is not the case on amd64.) >>> Fix this by skipping the set_vt_drv_set lookup if vbefb was = already >>> detected. >>> Reviewed by: tsoome >>=20 >> Does the state get reset if you unload one kernel and then load a = different >> one (e.g. via interactive 'unload' and 'load /path/to/my/kernel')? >=20 > Ha, good one! I don't think it is. >=20 > -Dimitry >=20 I=E2=80=99m about to push it:) yes, it was missed. thanks, toomas=