From owner-svn-src-head@freebsd.org Fri Jul 13 03:39:57 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id B51A0104B30B; Fri, 13 Jul 2018 03:39:57 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: from mail-pg1-x543.google.com (mail-pg1-x543.google.com [IPv6:2607:f8b0:4864:20::543]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 31F0F721D9; Fri, 13 Jul 2018 03:39:57 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: by mail-pg1-x543.google.com with SMTP id x5-v6so4530986pgp.7; Thu, 12 Jul 2018 20:39:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=5i+nH/xOvKbWkGCtpw9CHY+vTy6g6in1/ckjBtxApEc=; b=BUnnHsBiuqZ98utuAa4tRZnBTk6JlHaj57gunpcr2kUDJCbjuDzaVSKWghXkwBxg/W oa/5KVcAA1noGtRogSMKaZND6njsBKRYV/e++DXw9WtADQ/VAf6hjhUEJAULVkXQnqEX mJZUvNTfMwLhAbZBDtpWyfaNB9jfqYyYNe0f1fCSyE190R7wn//qEMHBw9sDZaBd4+bc x+b0l1lFZB+hv0xTW4opL40vn+i3dUnYoXzgOM0v3+3MVlHTBGuvrfLLjhOWO6nPLnnw zcOkiiCmnP0MA0DfGvdeqjTXZ7PZ8D5D1bjL/lrPIFZob9lYD2SEekimE0nyNm/a4oO0 4nIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=5i+nH/xOvKbWkGCtpw9CHY+vTy6g6in1/ckjBtxApEc=; b=VQ0uhHFwLRqBpxXMk4L8l5xFrtAWBGQQ1I8ywd/E4+v7GG851ROGHBxARAtRI2O3LQ eNjYWELb/lgal1J3LQ9tMQ6C3A8URmnAIM+8/YgHxq1mVXsw3+aS0vjhSifFkU1haFDy JzoMdhGVk1KI5jw2b+Hi0sx+IJaeU7Q8GHIVPOqS7mTZMGlYDGfn98di7EKTKir4y6DC lHDr+hMCNInLkju/kp5z/02Yq05xQyGs0YVEbOCBhthRpVX//CiGTmxtBqJGjIDq6Ner HWCOWoLmJ38arqFnz9cXgWTYnxV4CI0XoNHQs1n7dbA8A3ZSXLAz2M5M72w/kBQb3foQ RpDg== X-Gm-Message-State: AOUpUlEJT84YVq9liaX7b0lOrtHojoVvUZtukNp5q5jw5Nd9ECCGdcc9 IRO/KtjR8jIH+ndEqvERyDU= X-Google-Smtp-Source: AAOMgpdH8GSRiGeiMJisVGk+DVvtUoDfRTLfKbj155SnsdaCqQq0yRNpzk8imD6Jdob27c+z/+Ovfg== X-Received: by 2002:a62:4898:: with SMTP id q24-v6mr5130634pfi.58.1531453196151; Thu, 12 Jul 2018 20:39:56 -0700 (PDT) Received: from raichu (toroon0560w-lp130-09-70-52-224-107.dsl.bell.ca. [70.52.224.107]) by smtp.gmail.com with ESMTPSA id l79-v6sm48136908pfj.179.2018.07.12.20.39.53 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 12 Jul 2018 20:39:54 -0700 (PDT) Sender: Mark Johnston Date: Thu, 12 Jul 2018 23:39:51 -0400 From: Mark Johnston To: Mateusz Guzik Cc: Mateusz Guzik , src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r336231 - head/sys/vm Message-ID: <20180713033951.GB26064@raichu> References: <201807122235.w6CMZqO8030291@repo.freebsd.org> <20180712225856.GA26064@raichu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.0 (2018-05-17) X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 13 Jul 2018 03:39:58 -0000 On Fri, Jul 13, 2018 at 01:41:46AM +0200, Mateusz Guzik wrote: > uma_zone_get_cur iterates the per-cpu stats and looks at the zone-global > stats. The patch only gets rid of rolling them up, thus there is no > difference from the pov of this func. > I don't follow the remark about uma_reclaim. I'm pointing out that with this change we no longer maintain any zone-global stats. > On Fri, Jul 13, 2018 at 12:58 AM, Mark Johnston wrote: > > > On Thu, Jul 12, 2018 at 10:35:52PM +0000, Mateusz Guzik wrote: > > > Author: mjg > > > Date: Thu Jul 12 22:35:52 2018 > > > New Revision: 336231 > > > URL: https://svnweb.freebsd.org/changeset/base/336231 > > > > > > Log: > > > uma: whack main zone counter update in the slow path, freeing side > > > > > > See r333052. > > > > > > Modified: > > > head/sys/vm/uma_core.c > > > > > > Modified: head/sys/vm/uma_core.c > > > ============================================================ > > ================== > > > --- head/sys/vm/uma_core.c Thu Jul 12 22:34:40 2018 (r336230) > > > +++ head/sys/vm/uma_core.c Thu Jul 12 22:35:52 2018 (r336231) > > > @@ -3135,14 +3135,6 @@ zfree_start: > > > cpu = curcpu; > > > cache = &zone->uz_cpu[cpu]; > > > > > > - /* > > > - * Since we have locked the zone we may as well send back our > > stats. > > > - */ > > > - atomic_add_long(&zone->uz_allocs, cache->uc_allocs); > > > - atomic_add_long(&zone->uz_frees, cache->uc_frees); > > > - cache->uc_allocs = 0; > > > - cache->uc_frees = 0; > > > - > > > > Doesn't this break the accounting of these stats? uma_reclaim() doesn't > > update them when it frees cached items, and uma_zone_get_cur() doesn't > > look at the stats for cached buckets.