From owner-cvs-all  Fri Jun 22  3:32:24 2001
Delivered-To: cvs-all@freebsd.org
Received: from relay.nuxi.com (nuxi.cs.ucdavis.edu [169.237.7.38])
	by hub.freebsd.org (Postfix) with ESMTP
	id D194837B403; Fri, 22 Jun 2001 03:32:16 -0700 (PDT)
	(envelope-from obrien@nuxi.ucdavis.edu)
Received: from dragon.nuxi.com (root@trang.nuxi.com [206.40.252.115])
	by relay.nuxi.com (8.11.2/8.11.2) with ESMTP id f5MAWGR14302;
	Fri, 22 Jun 2001 03:32:16 -0700 (PDT)
	(envelope-from obrien@NUXI.com)
Received: (from obrien@localhost)
	by dragon.nuxi.com (8.11.3/8.11.1) id f5MAWFZ00795;
	Fri, 22 Jun 2001 03:32:15 -0700 (PDT)
	(envelope-from obrien)
Date: Fri, 22 Jun 2001 03:32:15 -0700
From: "David O'Brien" <obrien@FreeBSD.org>
To: Dag-Erling Smorgrav <des@FreeBSD.org>
Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/usr.bin/whois Makefile whois.c
Message-ID: <20010622033215.A302@dragon.nuxi.com>
Reply-To: obrien@FreeBSD.org
References: <200106220152.f5M1qd770887@freefall.freebsd.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.2.5i
In-Reply-To: <200106220152.f5M1qd770887@freefall.freebsd.org>; from des@FreeBSD.org on Thu, Jun 21, 2001 at 06:52:38PM -0700
X-Operating-System: FreeBSD 5.0-CURRENT
Organization: The NUXI BSD group
X-Pgp-Rsa-Fingerprint: B7 4D 3E E9 11 39 5F A3  90 76 5D 69 58 D9 98 7A
X-Pgp-Rsa-Keyid: 1024/34F9F9D5
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
List-ID: <cvs-all.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo?subject=subscribe%20cvs-all>
List-Unsubscribe: <mailto:majordomo?subject=unsubscribe%20cvs-all>
X-Loop: FreeBSD.ORG

On Thu, Jun 21, 2001 at 06:52:38PM -0700, Dag-Erling Smorgrav wrote:
> des         2001/06/21 18:52:38 PDT
> 
>   Modified files:
>     usr.bin/whois        Makefile whois.c 
>   Log:
>   Stylify, ANSIfy, silence warnings, plug a memory leak, don't assume the
>   server is well-behaved wrt. line endings.

Uh DES, you know perfectly well that style(9) commits should be separated
from functionality commits.  Why didn't you do this as at least two
commits?

Also why did you commit something that changed

    if (x) {
        if (y) 
            z;
    }

to just

    if (x)
        if (y)
            z;

when it is perfectly allowed by style(9)?

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message