From owner-svn-src-head@FreeBSD.ORG Sun Sep 16 18:38:05 2012 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 833731065675 for ; Sun, 16 Sep 2012 18:38:05 +0000 (UTC) (envelope-from lists@eitanadler.com) Received: from mail-pb0-f54.google.com (mail-pb0-f54.google.com [209.85.160.54]) by mx1.freebsd.org (Postfix) with ESMTP id 1755D8FC15 for ; Sun, 16 Sep 2012 18:38:04 +0000 (UTC) Received: by pbbrp2 with SMTP id rp2so8676950pbb.13 for ; Sun, 16 Sep 2012 11:38:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=eitanadler.com; s=0xdeadbeef; h=mime-version:sender:in-reply-to:references:from:date :x-google-sender-auth:message-id:subject:to:cc:content-type; bh=LmiwIronrD7Z01DBz6AmMXeW2eEJRla6L73fvD9KASc=; b=YozUTjtUIGX03lxR3sDwo2yWNrSSUrUOi1TEuTc3i1SeSTvFDmCraXagqvkEjCpYL5 xLpHYz4UHW/nFfWfexeYwvCGrDtoA2P8HofUgFSbzVksc/qwCxoRE3fGsXdd66+0MUQP x0xggjJPgCN23SoLp/p2CmjYxB4DT2bTH3p74= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date :x-google-sender-auth:message-id:subject:to:cc:content-type :x-gm-message-state; bh=LmiwIronrD7Z01DBz6AmMXeW2eEJRla6L73fvD9KASc=; b=AZr7ZZetcm4GRmLMvR4lk/iXeMtTSeb8f8ItYRJ7/3Ssba5qRxM6FmWBO35+o6uUC8 +5+/ZGXIgkhZkOnnVAivWvDpAk07tHutDwvMBbEbDzilgSe4vnf+fYOgsmhpuY/LEibQ ICG08a5rtql2tCNkzKmMMDKmARiRosWZhTH9tSpCAy98cgl0DxSfdlfwJClYN5lwhuJu IbglB5qWePZZXBS3xw+kD5BRGHH096kTIi4p0fxvOi+cpUa4fcvFCe0WfvWn3iWk8y+N AeEF4lhcooOMo4/ffhNN32VJE95j5RBqrhj5l28MKmckXPDekbpdx0yZ0xW0AUEglyIC dbXQ== Received: by 10.66.73.100 with SMTP id k4mr15547593pav.49.1347820681827; Sun, 16 Sep 2012 11:38:01 -0700 (PDT) MIME-Version: 1.0 Sender: lists@eitanadler.com Received: by 10.66.87.41 with HTTP; Sun, 16 Sep 2012 11:37:31 -0700 (PDT) In-Reply-To: References: <201209160755.q8G7tnMH036332@svn.freebsd.org> <20120916092818.GA81952@FreeBSD.org> <38FB39C4-7626-4D54-8197-E302BB9452D2@FreeBSD.org> <1347817284.1114.2.camel@revolution.hippie.lan> From: Eitan Adler Date: Sun, 16 Sep 2012 14:37:31 -0400 X-Google-Sender-Auth: lwVCgZQMLzZVERymXgTVArVn_vM Message-ID: To: Chris Rees Content-Type: text/plain; charset=UTF-8 X-Gm-Message-State: ALoCoQn2FVM1+MxtRo9C4a9YypucRYEmI9ndEMpbCQOJqZ3ItRI6y3mlXclPbWfVzVJwGb7PDF6e Cc: Ian Lepore , Alexey Dokuchaev , src-committers@freebsd.org, svn-src-all@freebsd.org, David Chisnall , Andrew Turner , Bruce Evans , svn-src-head@freebsd.org Subject: Re: svn commit: r240549 - head/sys/arm/tegra X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 16 Sep 2012 18:38:05 -0000 On 16 September 2012 13:45, Chris Rees wrote: > On 16 September 2012 18:41, Ian Lepore wrote: >> On Sun, 2012-09-16 at 18:30 +0100, Chris Rees wrote: >>> On 16 Sep 2012 16:19, "David Chisnall" wrote: >>> > >>> > On 16 Sep 2012, at 10:37, Chris Rees wrote: >>> > >>> > > Actually: >>> > > >>> > > for (;;) >>> > > ; >>> > >>> > This form will generate a compiler warning, because it looks like a >>> missing loop body. You can silence the warning by this form: >>> > >>> > for (;;) {} >>> > >>> > This makes it clear that you have an explicit body containing no >>> statements. >>> >>> Please fix the style man page then, and make sure bde approves! >> >> One of the examples allows >> >> for (;;) >> stmt; >> >> Using "continue;" as the statement is consistant with that. > > Ok, so with approval from a docs/src guy I'd like to commit [1] to > update the style page to use continue; instead of a lone ; > > Anyone like to approve/commit? +1 to your patch, though I prefer "do nothing" to "nothing." > > Chris > > [1] http://www.bayofrum.net/~crees/patches/style-empty-loop.diff > -- Eitan Adler Source & Ports committer X11, Bugbusting teams