YmMSBe4vhbg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1760451376; a=rsa-sha256; cv=none; b=cmJmQghVfTzBB/Qgth+nr1BS1B393U/bpliXmFtNwFirEDx5nfZD0W1qxaUGBjD2J0UKDl TTH7I5pDcfDlCcD6+GB6wpFOkh5WEiUMkwcBhLg1j0PNIuNdZDsj408uSOYZFyv/mg8+g2 2HcU5GXJ4M5borBF46/9DUiXkJPVwCTmW5UFdgrWhTX1k1CTtxOHCrONKnPgGmUcAGE1uz ll5xo7Hdi1MKhsyaQXTbNlvdc6BvbypLq77ZTGMZOO/smFeVOtR6M70unhaLUra8lPjSIz OunEWcqVIIomE9bjSYuqUn44Tlt9u5Dzb5C58tXqp00hH9A/SOqMGcAyQ4xYQQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4cmGV82VDjzwDs; Tue, 14 Oct 2025 14:16:16 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 59EEGGP3028160; Tue, 14 Oct 2025 14:16:16 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 59EEGGs5028157; Tue, 14 Oct 2025 14:16:16 GMT (envelope-from git) Date: Tue, 14 Oct 2025 14:16:16 GMT Message-Id: <202510141416.59EEGGs5028157@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Ahmad Khalifa Subject: git: d06e31d4a762 - stable/13 - libm: remainder: make sure x is zero List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: vexeduxr X-Git-Repository: src X-Git-Refname: refs/heads/stable/13 X-Git-Reftype: branch X-Git-Commit: d06e31d4a7622b535d903a1b84ce59e211ca2b18 Auto-Submitted: auto-generated The branch stable/13 has been updated by vexeduxr: URL: https://cgit.FreeBSD.org/src/commit/?id=d06e31d4a7622b535d903a1b84ce59e211ca2b18 commit d06e31d4a7622b535d903a1b84ce59e211ca2b18 Author: Ahmad Khalifa AuthorDate: 2025-10-10 09:30:52 +0000 Commit: Ahmad Khalifa CommitDate: 2025-10-14 14:01:59 +0000 libm: remainder: make sure x is zero Make sure the entirety of x is zero before flipping the sign bit. Otherwise the sign would be wrong for small values of x when x is negative and |n*y| > |x| Reported by: alfredo PR: 251091 Reviewed by: kargl MFC after: 3 days Differential Revision: https://reviews.freebsd.org/D53023 (cherry picked from commit 25cca51ed294890d20a3c0290814cd26875db686) --- lib/msun/src/e_remainder.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/msun/src/e_remainder.c b/lib/msun/src/e_remainder.c index bd1ce8950619..5b71088911a2 100644 --- a/lib/msun/src/e_remainder.c +++ b/lib/msun/src/e_remainder.c @@ -66,8 +66,8 @@ remainder(double x, double p) if(x>=p_half) x -= p; } } - GET_HIGH_WORD(hx,x); - if ((hx&0x7fffffff)==0) hx = 0; + EXTRACT_WORDS(hx, lx, x); + if (((hx&0x7fffffff)|lx) == 0) hx = 0; SET_HIGH_WORD(x,hx^sx); return x; }