From nobody Thu Dec 2 05:40:06 2021 X-Original-To: dev-commits-ports-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id A830F18BA581; Thu, 2 Dec 2021 05:40:06 +0000 (UTC) (envelope-from danfe@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2610:1c1:1:6074::16:84]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "freefall.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4J4PtG4MNbz4j5t; Thu, 2 Dec 2021 05:40:06 +0000 (UTC) (envelope-from danfe@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1638423606; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=obUGM/u36bfNnd6+UZ58XTn/OwAMW6sK/U2R+7NdQTU=; b=CupsYTvrqc6O7HfJYNqyxGE571uK5ul7/AQKTXfGZjMX8YSDZAxkLT+vMcns2lNhikVELR CB7ShGMdBmL8qsNrKAgaEWocFwjEKVIDmkqPBAD55/Um9VSnYSz2NIQdnd4KDZ7V3tEs49 G6et7aOJL4+Wj+nDlN5MwgG+nEPHhIOxdQD9DykDaqgZAa5yIY8ps/0RnY7i7A608dIxAO PWQq/5zseYdXqFJcxTmnUOw1djpQODu9oF++3e/GbWmR82GmFmbeP6rY9YpL3asP8KjTnc 9AU1a3I7EVEfI6oZzOsHM7OgTSd01sTVsXwxDQEEEtjcEXrXz7Te7bfyoMG+nQ== Received: by freefall.freebsd.org (Postfix, from userid 1033) id 866D99B70; Thu, 2 Dec 2021 05:40:06 +0000 (UTC) Date: Thu, 2 Dec 2021 05:40:06 +0000 From: Alexey Dokuchaev To: Don Lewis Cc: Cy Schubert , Kubilay Kocak , Cy Schubert , ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: b8c4bfe660b3 - main - sysutils/reptyr: Address LLVM 13 build failure Message-ID: References: <202112020054.1B20sZXk040844@gitrepo.freebsd.org> <202112020412.1B24CA8G016980@slippy.cwsent.com> List-Id: Commit messages for all branches of the ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-all@freebsd.org X-BeenThere: dev-commits-ports-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1638423606; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=obUGM/u36bfNnd6+UZ58XTn/OwAMW6sK/U2R+7NdQTU=; b=UsTKSqdJ/czVHMl4yjHApE03/VQJtlNGkUp5lk9M7A6Rke6txXfpf7x+mulyPBA/0RB+mI Y+er8/oBF5lwbb52d42+LUIHJx5DfICZixJkg/d9goWqFG7qQD7V9+y+xPtqVXTN/s2RaE 3BtBiRquNy8WQqK84tUpTCQDOjS6GOSQfYYmC2CjkmX/Pa8IYC0JNvv+CafwrRT+EtCnZV 06oMPBcXtf8UT/yBzHooZHiJ1xdJlwcB6pDnadHbZour4Fapah8fejSqcy1CHQ+/vvkCH6 DwTuPaiItK3iOTE8kEzTetJc9MkGPVH+OuvvmzOPZZgFKYXjhYBErELGsqTrsg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1638423606; a=rsa-sha256; cv=none; b=RwB6jmGu8uoC6lyo6iDTdgirlxbMZm58qKA6K75cjQ8oCJJREMBdOLNAuj3fzbTUM954E+ dz9uxmQrPHcrOj+VKOtI1POKh1jmYRVE0Ixxh73Xz/jmaMbb3WsifMEQrAl1Y2/7Y/XTXC +92uVRhp/tqvN0acV4LLHuns9wmwIIraLwc4JSCOFclRwH+EwLIMDNk4GQJS4oQwY6FMfG 75tc+LYyaMtuRf72khBdQLHgrLgX/JNij8uTFJUldrW6DGd7ihgEO80GHDnpmd7RAIj8+V nKXRSZBOCYRSP8EXDuShj9yEfwlwz4Zs3WrBtsm3O0+tmbkXGr0SN+FdMJyLLw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N On Wed, Dec 01, 2021 at 09:28:36PM -0800, Don Lewis wrote: > ... > In one particular case, I'm working with some really crufty old C code > that's been abandoned for quite some time. Compiling it throws tons of > errors about things that were mentioned favorably in the original K&R C > book. The code badly needs cleanup, much of which look like it is > fairly mechanical, but it would be too easy to introduce bugs and there > is no test harness that I'm aware of to do a thorough test of the > updated code. > > Another case is a large C++ project where many of the errors are due to > an API problem in a base class that is used by many other classes, some > of which override the problematic method. Fixing the API issue in the > base class ripples out to *many* other places and doing an adequate job > of testing looks like a lot of work. Naturally, when working with old, unmaintained, or convoluted codebases one should use their knowledge of these particular circumstances to make the best judgment. It is indeed often safer to tune the compiler rather than patch fragile, warny, but nonetheless working code. My point here is, when taking "tame the compiler" approach, not to tranquilize it too much, as it would stop telling you about the bugs you're *unaware* of. Having these individual -Wno-... flags are quite handy for that purpose. ./danfe