From owner-svn-src-head@FreeBSD.ORG Fri Sep 12 21:55:30 2014 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 06A0B464; Fri, 12 Sep 2014 21:55:30 +0000 (UTC) Received: from bigwig.baldwin.cx (bigwig.baldwin.cx [IPv6:2001:470:1f11:75::1]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id D25EAED6; Fri, 12 Sep 2014 21:55:29 +0000 (UTC) Received: from ralph.baldwin.cx (pool-173-70-85-31.nwrknj.fios.verizon.net [173.70.85.31]) by bigwig.baldwin.cx (Postfix) with ESMTPSA id 520AAB94C; Fri, 12 Sep 2014 17:55:28 -0400 (EDT) From: John Baldwin To: src-committers@freebsd.org Subject: Re: svn commit: r271489 - in head/sys: kern ofed/include/linux opencrypto sys Date: Fri, 12 Sep 2014 17:44:15 -0400 Message-ID: <352667542.FMiDv6jZct@ralph.baldwin.cx> User-Agent: KMail/4.10.5 (FreeBSD/10.0-STABLE; KDE/4.10.5; amd64; ; ) In-Reply-To: <201409122129.s8CLTBZ0070756@svn.freebsd.org> References: <201409122129.s8CLTBZ0070756@svn.freebsd.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7 (bigwig.baldwin.cx); Fri, 12 Sep 2014 17:55:28 -0400 (EDT) Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 12 Sep 2014 21:55:30 -0000 On Friday, September 12, 2014 09:29:11 PM John Baldwin wrote: > Author: jhb > Date: Fri Sep 12 21:29:10 2014 > New Revision: 271489 > URL: http://svnweb.freebsd.org/changeset/base/271489 > > Log: > Fix various issues with invalid file operations: > - Add invfo_rdwr() (for read and write), invfo_ioctl(), invfo_poll(), > and invfo_kqfilter() for use by file types that do not support the > respective operations. Home-grown versions of invfo_poll() were > universally broken (they returned an errno value, invfo_poll() > uses poll_no_poll() to return an appropriate event mask). Home-grown > ioctl routines also tended to return an incorrect errno (invfo_ioctl > returns ENOTTY). > - Use the invfo_*() functions instead of local versions for > unsupported file operations. > - Reorder fileops members to match the order in the structure definition > to make it easier to spot missing members. > - Add several missing methods to linuxfileops used by the OFED shim > layer: fo_write(), fo_truncate(), fo_kqfilter(), and fo_stat(). Most > of these used invfo_*(), but a dummy fo_stat() implementation was > added. For this last, if you managed to get a handle to one of these file descriptors using any of the associated system calls (write(), fstat(), etc.) would trigger an instant-panic. I don't think that non-root users can get to these descriptors however. -- John Baldwin