From owner-freebsd-ports@FreeBSD.ORG  Sat Feb 23 12:43:13 2013
Return-Path: <owner-freebsd-ports@FreeBSD.ORG>
Delivered-To: ports@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by hub.freebsd.org (Postfix) with ESMTP id 0C6BBFD9
 for <ports@freebsd.org>; Sat, 23 Feb 2013 12:43:13 +0000 (UTC)
 (envelope-from amdmi3@amdmi3.ru)
Received: from smtp.timeweb.ru (smtp.timeweb.ru [92.53.116.15])
 by mx1.freebsd.org (Postfix) with ESMTP id 7CB15C26
 for <ports@freebsd.org>; Sat, 23 Feb 2013 12:43:12 +0000 (UTC)
Received: from [213.148.20.85] (helo=hive.panopticon)
 by smtp.timeweb.ru with esmtpsa (TLS1.0:DHE_RSA_CAMELLIA_256_CBC_SHA1:256)
 (Exim 4.80) (envelope-from <amdmi3@amdmi3.ru>)
 id 1U9ERU-0004yP-In; Sat, 23 Feb 2013 16:43:04 +0400
Received: from hades.panopticon (hades.panopticon [192.168.0.32])
 by hive.panopticon (Postfix) with ESMTP id F0FD6B84D;
 Sat, 23 Feb 2013 16:43:03 +0400 (MSK)
Received: by hades.panopticon (Postfix, from userid 1000)
 id E6E40455; Sat, 23 Feb 2013 16:43:03 +0400 (MSK)
Date: Sat, 23 Feb 2013 16:43:03 +0400
From: Dmitry Marakasov <amdmi3@amdmi3.ru>
To: Chris Rees <utisoft@gmail.com>
Subject: Re: CONFIGURE_ENV and CPPFLAGS
Message-ID: <20130223124303.GO99263@hades.panopticon>
References: <CAF6rxgnoyNMvpa_RDZi8Rf4HpZ139KL=ZARP9tHOETbiJjU2rA@mail.gmail.com>
 <CADLo83_bb=WQyMxu1wqnVeHn6ncZ-cACTtcVXDDYAdCwUNg=QQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <CADLo83_bb=WQyMxu1wqnVeHn6ncZ-cACTtcVXDDYAdCwUNg=QQ@mail.gmail.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Cc: ports@freebsd.org, Eitan Adler <lists@eitanadler.com>
X-BeenThere: freebsd-ports@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Porting software to FreeBSD <freebsd-ports.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-ports>,
 <mailto:freebsd-ports-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports>
List-Post: <mailto:freebsd-ports@freebsd.org>
List-Help: <mailto:freebsd-ports-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
 <mailto:freebsd-ports-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 23 Feb 2013 12:43:13 -0000

* Chris Rees (utisoft@gmail.com) wrote:

> > commit 687519c34ad3423752268a0a20d079fda9cea8b2
> > Author: Eitan Adler <lists@eitanadler.com>
> > Date:   Fri Feb 22 18:43:30 2013 -0500
> >
> >     Using CONFIGURE_ENV for CPPFLAGS and
> >     LDFLAGS is not needed since r282433.
> >
> >     PR:         docs/174827
> >     Submitted by:       Dominique Goncalves <dominique.goncalves@gmail.com
> >
> >
> > diff --git a/en_US.ISO8859-1/books/porters-handbook/book.xml
> > b/en_US.ISO8859-1/books/porters-handbook/book.xml
> > index ef50257..c64cdc7 100644
> > --- a/en_US.ISO8859-1/books/porters-handbook/book.xml
> > +++ b/en_US.ISO8859-1/books/porters-handbook/book.xml
> > @@ -5726,17 +5726,13 @@ IGNORE= may not be redistributed because of
> > licensing reasons. Please visit <rep
> >  CPPFLAGS+=     -I${LOCALBASE}/include
> >  LDFLAGS+=      -L${LOCALBASE}/lib
> >
> > -GNU_CONFIGURE= yes
> > -CONFIGURE_ENV= CPPFLAGS="${CPPFLAGS}" \
> > -               LDFLAGS="${LDFLAGS}"</programlisting>
> > +GNU_CONFIGURE= yes</programlisting>
> >
> >         <para>Of course, the code can be more compact if there are no
> >           more flags to pass to <command>configure</command>:</para>
> >
> >         <programlisting>USE_GETTEXT=    yes
> > -GNU_CONFIGURE= yes
> > -CONFIGURE_ENV= CPPFLAGS="-I${LOCALBASE}/include" \
> > -               LDFLAGS="-L${LOCALBASE}/lib"</programlisting>
> > +GNU_CONFIGURE= yes</programlisting>
> >        </sect2>
> >
> >        <sect2>
> >
> 
> I'm pretty sure this is correct, but we should do one final check with
> Dmitry.

Yes, this is correct.

-- 
Dmitry Marakasov   .   55B5 0596 FF1E 8D84 5F56  9510 D35A 80DD F9D2 F77D
amdmi3@amdmi3.ru  ..:  jabber: amdmi3@jabber.ru    http://www.amdmi3.ru