From owner-cvs-all@FreeBSD.ORG Tue Jan 20 12:40:05 2004 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A6B2616A4CE; Tue, 20 Jan 2004 12:40:05 -0800 (PST) Received: from critter.freebsd.dk (critter.freebsd.dk [212.242.86.163]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6CCEF43D82; Tue, 20 Jan 2004 12:39:21 -0800 (PST) (envelope-from phk@phk.freebsd.dk) Received: from critter.freebsd.dk (localhost [127.0.0.1]) by critter.freebsd.dk (8.12.10/8.12.10) with ESMTP id i0KKdICf009203; Tue, 20 Jan 2004 21:39:19 +0100 (CET) (envelope-from phk@phk.freebsd.dk) To: John Baldwin From: "Poul-Henning Kamp" In-Reply-To: Your message of "Tue, 20 Jan 2004 14:45:24 EST." <200401201445.24897.jhb@FreeBSD.org> Date: Tue, 20 Jan 2004 21:39:18 +0100 Message-ID: <9202.1074631158@critter.freebsd.dk> cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/alpha/alpha support.s src/sys/i386/i386 swtch.s src/sys/kern kern_shutdown.c src/sys/sys systm.h X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Jan 2004 20:40:05 -0000 In message <200401201445.24897.jhb@FreeBSD.org>, John Baldwin writes: >On Tuesday 20 January 2004 01:23 pm, Poul-Henning Kamp wrote: >> In message <200401201234.45472.jhb@FreeBSD.org>, John Baldwin writes: >> >On Monday 19 January 2004 04:27 pm, Poul-Henning Kamp wrote: >> >> Log: >> >> Add linenumber and source filename to panic(9) output. This thread already represents a prime example of the worst of the FreeBSD projects social dimension: The Gratuituos Bike Shed. On a generic kernel, this change adds 32088 non-executed bytes of text-segment to i386/GENERIC. For reference this 0.5% of the kernel and 12% of the size of the ACPI module. The email generated by this bike-shed however, has already occupied more disk-space on my computers than the kernel change ever will, and chances are that we have not even seen the tip of that iceberg. May I kindly remind you all that even if one person doesn't find that it adds anything to his already trained skills as a debugger, it does make life easier for other less gifted people in our project, or God forbid: actual users who may try to report a problem. And yes, we can do much better, tracebacks would be a great start, better panics also a great thing. And no, this does not solve the mid-east crisis, but it is still an improvement, even for me: If I save 1 minute because I do not have to hunt for the panic in the first place, then that is one minute more I can spend on the code. So if this makes your eyes water, I suggest you comment it out in your local source tree and pop in on the next meeting in your local user-group for some much needed perspective. Poul-Henning -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence.