From owner-freebsd-hackers@FreeBSD.ORG Sun Jan 11 08:43:05 2004 Return-Path: Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 16FA616A4CE for ; Sun, 11 Jan 2004 08:43:05 -0800 (PST) Received: from fledge.watson.org (fledge.watson.org [204.156.12.50]) by mx1.FreeBSD.org (Postfix) with ESMTP id A736A43D5E for ; Sun, 11 Jan 2004 08:43:02 -0800 (PST) (envelope-from robert@fledge.watson.org) Received: from fledge.watson.org (localhost [127.0.0.1]) by fledge.watson.org (8.12.10/8.12.10) with ESMTP id i0BGfIUd090101; Sun, 11 Jan 2004 11:41:18 -0500 (EST) (envelope-from robert@fledge.watson.org) Received: from localhost (robert@localhost)i0BGfHMM090098; Sun, 11 Jan 2004 11:41:18 -0500 (EST) (envelope-from robert@fledge.watson.org) Date: Sun, 11 Jan 2004 11:41:17 -0500 (EST) From: Robert Watson X-Sender: robert@fledge.watson.org To: Danny Braniss In-Reply-To: Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII cc: hackers@freebsd.org Subject: Re: diskless problems X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 11 Jan 2004 16:43:05 -0000 On Sun, 11 Jan 2004, Danny Braniss wrote: > while the subject is being revived, there are some changes/additions I > made to libstand/bootp.c, it exports all the dhcp tags so that they are > available to rc.diskless? or rc.d/initdiskless via kenv check out > ftp://ftp.cs.huji.ac.il/users/danny/freebsd/diskless-boot/ > > these are a bit date, but the uptodated stuff is actively being used > here, so if there is some interest i could update it. Sounds very interesting indeed. Could you: (1) Update it to bootp.c:1.5; this just removed 'register', and it looks like you've already done that. (2) Restore the original file style -- right now, it's a very hard to read diff because you use different tabbing, function prototypes, etc, so it's hard to isolate and read the changes. There's probably some room for style convergence (new function prototypes), but we have a long-standing tradition of committing style and functional chaanges separately so cvs diff is maximally useful between revisions. It looks like the main difference is that you use four space tabs, and the original file uses real tab characters. Then if you could file a PR and drop me the PR number by e-mail, that would be great. I can do the style stuff if necessary, but I figured since you're much more familiar with the changes, it might not be a bad idea if you did it :-). Robert N M Watson FreeBSD Core Team, TrustedBSD Projects robert@fledge.watson.org Senior Research Scientist, McAfee Research