From owner-freebsd-git@freebsd.org Fri Jan 1 11:58:56 2021 Return-Path: Delivered-To: freebsd-git@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 749154C660B for ; Fri, 1 Jan 2021 11:58:56 +0000 (UTC) (envelope-from uqs@freebsd.org) Received: from mailman.nyi.freebsd.org (unknown [127.0.1.3]) by mx1.freebsd.org (Postfix) with ESMTP id 4D6k802ryBz4lKG for ; Fri, 1 Jan 2021 11:58:56 +0000 (UTC) (envelope-from uqs@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id 61E954C5ABF; Fri, 1 Jan 2021 11:58:56 +0000 (UTC) Delivered-To: git@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 61B004C641D for ; Fri, 1 Jan 2021 11:58:56 +0000 (UTC) (envelope-from uqs@freebsd.org) Received: from acme.spoerlein.net (acme.spoerlein.net [IPv6:2a05:fc87:1:5::15]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "www.spoerlein.net", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4D6k80174Tz4lM4; Fri, 1 Jan 2021 11:58:55 +0000 (UTC) (envelope-from uqs@freebsd.org) Received: from localhost (acme.spoerlein.net [IPv6:2a05:fc87:1:5:0:0:0:15]) by acme.spoerlein.net (8.16.1/8.15.2) with ESMTPS id 101Bws9x036638 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Fri, 1 Jan 2021 12:58:54 +0100 (CET) (envelope-from uqs@freebsd.org) Date: Fri, 1 Jan 2021 12:58:54 +0100 From: Ulrich =?utf-8?B?U3DDtnJsZWlu?= To: Ed Maste Cc: John Baldwin , git@freebsd.org Subject: Re: Thoughts on git commit mail Message-ID: References: <2bff94da-deb9-2410-b580-441eb31c8d40@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: User-Agent: Mutt/2.0.1 (2020-11-14) X-Rspamd-Queue-Id: 4D6k80174Tz4lM4 X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-BeenThere: freebsd-git@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Discussion of git use in the FreeBSD project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 01 Jan 2021 11:58:56 -0000 On Thu, 2020-12-31 at 19:03:37 -0500, Ed Maste wrote: >On Thu, 31 Dec 2020 at 17:14, John Baldwin wrote: >> >> The mix of fields for name and date is a bit odd though. Perhaps another >> alternative might be to elide the Author fields if the Author == Committer? >> That would keep a lean format when when the individuals are the same. >> For that suggestion, I think you would always show the two Commit fields >> ("Committer" and "CommitDate") and only show "Author" and "AuthorDate" >> if Author != Committer? > >I discussed this a bit with John on IRC, but for the benefit of the list: > >We expect Author == Committer will be common, and the commit date is >probably the more interesting date. In addition, committer will always >be someone@FreeBSD.org, so what about if we take John's suggestion for >Date, and use the author name, appending (via /committer/) if it's not >the author? > >Thus, for the example above: > >Author: John Baldwin (via rlibby) >Date: 2020-12-31 19:56:33 +0000 > >This is nice and concise while conveying all useful information, IMO. >This would work identically for MFCs of commits made by other >committers, as well as committing changes submitted by 3rd parties. I have no strong preference either way (because I use git log if I want to find out about things, something that now everyone has downloaded and is fast, as compared to SVN, so maybe behaviors need to change a little.) Should we drop Committer and CommitDate from the logs entirely, because 99% of the time it's just what is in the commit email From: and Date: headers anyway? The thing is, folks that take their information from commit emails see the Date of the push and usually who pushed it (Committer) in their email client. The really nice information on these MFCs is, how old their actual author date is, as that shows you how laggy we are with MFC'ing. And for commits to head, it's super interesting to see the potential 3rd party Authors we'll see in the future, and, again, the committer and the push date is shown in the email headers, so it's kinda redundant. I would be biased against a more dynamic format that only sometimes shows information and sometimes doesn't, as that can be confusing. Cheers Uli