From owner-cvs-all@FreeBSD.ORG Tue May 6 08:06:51 2003 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A28B937B401 for ; Tue, 6 May 2003 08:06:51 -0700 (PDT) Received: from mgr2.xmission.com (mgr2.xmission.com [198.60.22.202]) by mx1.FreeBSD.org (Postfix) with ESMTP id BCF0443FBD for ; Tue, 6 May 2003 08:06:50 -0700 (PDT) (envelope-from glewis@eyesbeyond.com) Received: from mail by mgr2.xmission.com with spam-scanned (Exim 3.35 #1) id 19D3tf-0007kr-02 for cvs-all@freebsd.org; Tue, 06 May 2003 08:58:23 -0600 Received: from [207.135.128.145] (helo=misty.eyesbeyond.com) by mgr2.xmission.com with esmtp (Exim 3.35 #1) id 19D3oM-0005kb-02; Tue, 06 May 2003 08:52:55 -0600 Received: from misty.eyesbeyond.com (localhost.eyesbeyond.com [127.0.0.1]) by misty.eyesbeyond.com (8.12.9/8.12.9) with ESMTP id h46EvZQf008105; Tue, 6 May 2003 08:57:35 -0600 (MDT) (envelope-from glewis@eyesbeyond.com) Received: (from glewis@localhost) by misty.eyesbeyond.com (8.12.9/8.12.9/Submit) id h46EvXjB008104; Tue, 6 May 2003 08:57:33 -0600 (MDT) X-Authentication-Warning: misty.eyesbeyond.com: glewis set sender to glewis@eyesbeyond.com using -f Date: Tue, 6 May 2003 08:57:33 -0600 From: Greg Lewis To: Mario Sergio Fujikawa Ferreira Message-ID: <20030506145733.GA8070@misty.eyesbeyond.com> References: <200305060611.h466B2io078265@repoman.freebsd.org> <20030506133458.2393.qmail@exxodus.fedaykin.here> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20030506133458.2393.qmail@exxodus.fedaykin.here> User-Agent: Mutt/1.4.1i X-Spam-Status: No, hits=-3.5 required=8.0 tests=IN_REP_TO,QUOTED_EMAIL_TEXT,REFERENCES, SIGNATURE_SHORT_DENSE,SPAM_PHRASE_00_01,USER_AGENT, USER_AGENT_MUTT,X_AUTH_WARNING version=2.43 X-Spam-Level: cc: cvs-ports@FreeBSD.org cc: Greg Lewis cc: cvs-all@FreeBSD.org cc: ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/java/jdk13/files patch-iomgr.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 06 May 2003 15:06:52 -0000 On Tue, May 06, 2003 at 10:34:36AM -0300, Mario Sergio Fujikawa Ferreira wrote: > On Mon, May 05, 2003 at 11:10:40PM -0700, Greg Lewis wrote: > > glewis 2003/05/05 23:11:02 PDT > > > > FreeBSD ports repository > > > > Added files: > > java/jdk13/files patch-iomgr.c > > Log: > > . Remove an assert() which asserts that if isatty() is true then > > ttyname() must not return NULL. This isn't entirely true according > > to the manual page (the device must be able to be found as well) and > > certainly appears to not necessarily be true in the package building > > environment on bento (plus at least the PR submitter's environment). > > > > Note that this assert() was, of course, only ever triggered when > > running in debug mode (which most people don't, but does happen > > during the build in some parts). Also note that there is a check > > for isatty() preceding the call for ttyname() and a NULL return > > from ttyname() is handled, so removing this assert should not > > create any problems. > > Shouldn't we bump PORTREVISION? Not for this commit (its only come up in very rare cases, and for those cases they wouldn't have been able to build). However, I should have bumped it for the Math.pow() fix. Thanks for the reminder :). -- Greg Lewis Email : glewis@eyesbeyond.com Eyes Beyond Web : http://www.eyesbeyond.com Information Technology FreeBSD : glewis@FreeBSD.org