From nobody Thu Jun 12 06:19:52 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4bHsnl5nS3z5yDR7; Thu, 12 Jun 2025 06:19:55 +0000 (UTC) (envelope-from glebius@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4bHsnl559Bz48TV; Thu, 12 Jun 2025 06:19:55 +0000 (UTC) (envelope-from glebius@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1749709195; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=CSj60OH6YzufIGogPQywt2O4ulNv5OuYCZcA4/Lef9A=; b=LwrSNyDNeXf852Myc52r/df64c4gm7eXc8Ujjvu3lhcfTF0P4rJifP6+sGjbybL20oH+0a kEKgU4fBPqhagkCGiYpOV5Z5vfVM0/Wvs2t0DdBhDC73ZnfOaz3NupQcvnGq8KeUHK96cX Q8w4tyQfq2mV+sFJMoUgFE1VaiVXPOSI9PbN4ENFNXjBgYaz/8msax1th7eTK1mc1F8mgy C7/wzUJ8cgsMOMjWenRDBfE/lS7BET9mRcm8bAUavnyOpPZcmZzxcCA1VgnYmm3GRkwVbt eRWP8zm5QaAk4MPKdt+KpO/zzzwrO5kZPGs8UO0EeeQgpA6t04t4CUKTs5VvDw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1749709195; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=CSj60OH6YzufIGogPQywt2O4ulNv5OuYCZcA4/Lef9A=; b=jSWpON2n/Kmbq9fh0hadbuNe/SZEtSIF02ZSihR6ncV5N37YGHiXQsy0dEQcMsqna8R3hw ksdUmGrtDNkEtMxX6ELgj6xbiJWl7+meF4Ivr/WfmDRQLO6XcyOCW//E3SHStxHIXk0cMd Njr1J45dOCjGb61WpUG9QJ1iDaGwh4nZ+LqO9st2E1sc2r5ivRDruEZ2C7pf1lK5uXi+mM 1Scshb0RfmnHStwzjY8NgRjrsAYkUq4egvYite3iE8YZBSiu/4/kCzDUihXvoUbOUuYrqq xgUM5HXvjTwQFAZtMl0hp73EPUat7b3BzakQ4hONtbhlhpJJ2QoB8wlp+IQrVg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1749709195; a=rsa-sha256; cv=none; b=cB+n9eEgfMw7itxCgRFHVre82f/cdSPeOymCEj+4QTVWV+2isXoKhtMQo1LhsVypFEJknF G0uoYouGQH0iE2b03tNqjm1SpXRbQ6gsA3G1mUnyNDVC/BJ8pVLg0qUlBtvHLrSYiXuCCF va9C++KzG+Cj7P0DQVKnAzzzwP/iF3g/3QzKHTVM6nhQh6C/LBnCh/bEHPGd5qzWFCogfk CSNehbGct7oSPUKG/l7zFs4NMPbfPrRrJu0FX8PczbpB6Y7wHxXRC8gdF1z5IvpUWBE4Et TFs/lCsjBr8aPQEWfluEAYbpkxzpiWy594QyhhX3c82ef8qzR/AxHrj+SFxzzQ== Received: from cell.glebi.us (glebi.us [162.251.186.162]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: glebius) by smtp.freebsd.org (Postfix) with ESMTPSA id 4bHsnk6Yq4z9LJ; Thu, 12 Jun 2025 06:19:54 +0000 (UTC) (envelope-from glebius@freebsd.org) Date: Wed, 11 Jun 2025 23:19:52 -0700 From: Gleb Smirnoff To: Konstantin Belousov Cc: Rick Macklem , Dag-Erling =?iso-8859-1?Q?Sm=F8rgrav?= , src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 79d0f4474653 - main - rpcbind: Ensure krpc is present. Message-ID: References: List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Wed, Jun 11, 2025 at 07:05:45AM +0300, Konstantin Belousov wrote: K> On Tue, Jun 10, 2025 at 08:41:44AM -0700, Gleb Smirnoff wrote: K> > On Tue, Jun 10, 2025 at 12:11:18PM +0300, Konstantin Belousov wrote: K> > K> Apparently we already have the feature called 'warmstart', where rpcbind K> > K> can be restarted and existing registrations are reloaded. So it is in K> > K> fact already solved, assuming admin is careful enough to use -w. K> > K> > Ok, then all that needs to be done is revert this: K> > K> > --- a/usr.sbin/rpcbind/rpcbind.c K> > +++ b/usr.sbin/rpcbind/rpcbind.c K> > @@ -159,10 +159,6 @@ main(int argc, char *argv[]) K> > K> > update_bound_sa(); K> > K> > - /* Ensure krpc is loaded */ K> > - if (modfind("krpc") < 0 && kldload("krpc") < 0) K> > - err(1, "krpc"); K> > - K> > /* Check that another rpcbind isn't already running. */ K> > if ((rpcbindlockfd = open(RPCBINDDLOCK, O_RDONLY|O_CREAT, 0444)) < 0) K> > err(1, "%s", RPCBINDDLOCK); K> Well, absolutely minimal fix would be to change err() to warn(). Kostik, please just commit this. Just one suggestion: make the warn() message more verbose: warn("failed to load krpc module, RPC services for kernel disabled"); -- Gleb Smirnoff