From owner-svn-src-head@FreeBSD.ORG Thu Dec 22 16:31:01 2011 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 5060B106566C; Thu, 22 Dec 2011 16:31:01 +0000 (UTC) (envelope-from adrian.chadd@gmail.com) Received: from mail-vw0-f54.google.com (mail-vw0-f54.google.com [209.85.212.54]) by mx1.freebsd.org (Postfix) with ESMTP id AA9AB8FC1C; Thu, 22 Dec 2011 16:31:00 +0000 (UTC) Received: by vbbfr13 with SMTP id fr13so11949884vbb.13 for ; Thu, 22 Dec 2011 08:31:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=G6P79DUFVAKSFhhhdBfh7Os2bEu48/Q/MEn/keRNlwg=; b=j4uNAdtQWZFsX5FCqnteSoBXdZpM++ggBjKxRODrxVfhUf65V1wPcpfGGKIPVZuEP8 BEMNtsI0Uq9QUR6y9nPc2yApipGTv3tgmU3qwfSFd3cbJFIgZ0kYdzwMRE1Vm6wZRdCy ziq8rGE/gkr6PXHOwVsEshvEd+3VsWYZtOscg= MIME-Version: 1.0 Received: by 10.52.94.75 with SMTP id da11mr6127776vdb.111.1324571460000; Thu, 22 Dec 2011 08:31:00 -0800 (PST) Sender: adrian.chadd@gmail.com Received: by 10.52.158.104 with HTTP; Thu, 22 Dec 2011 08:30:59 -0800 (PST) In-Reply-To: <201112221409.pBME980v020110@svn.freebsd.org> References: <201112221409.pBME980v020110@svn.freebsd.org> Date: Thu, 22 Dec 2011 08:30:59 -0800 X-Google-Sender-Auth: jvgDb4jXxa-Gobv2-vFjRaNL1h4 Message-ID: From: Adrian Chadd To: Dimitry Andric Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r228800 - in head/sys/dev/ath/ath_hal: ar5212 ar5416 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 22 Dec 2011 16:31:01 -0000 Just to be silly :) I reviewed this patchset early this morning and it's fi= ne. Nothing in the FreeBSD HAL uses the compression code, so unless someone out there has proprietary extensions which does, this patch is fine. I promise to get the AR5210 and AR5211 stuff tested tonight. The AR5210 at least works fine with -9 and -HEAD before the patch; the AR5211 is broken when trying to do WPA so I'll have to fix that first. Thanks, Adrian On 22 December 2011 06:09, Dimitry Andric wrote: > Author: dim > Date: Thu Dec 22 14:09:08 2011 > New Revision: 228800 > URL: http://svn.freebsd.org/changeset/base/228800 > > Log: > =A0Revert r228786. =A0We'll need to work around the warnings in another w= ay. > > =A0Requested by: adrian > =A0MFC after: =A0 =A01 week > > Modified: > =A0head/sys/dev/ath/ath_hal/ar5212/ar5212_misc.c > =A0head/sys/dev/ath/ath_hal/ar5416/ar5416_misc.c > > Modified: head/sys/dev/ath/ath_hal/ar5212/ar5212_misc.c > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- head/sys/dev/ath/ath_hal/ar5212/ar5212_misc.c =A0 =A0 =A0 Thu Dec 22 = 13:47:36 2011 =A0 =A0 =A0 =A0(r228799) > +++ head/sys/dev/ath/ath_hal/ar5212/ar5212_misc.c =A0 =A0 =A0 Thu Dec 22 = 14:09:08 2011 =A0 =A0 =A0 =A0(r228800) > @@ -574,7 +574,7 @@ ar5212SetDecompMask(struct ath_hal *ah, > =A0 =A0 =A0 =A0struct ath_hal_5212 *ahp =3D AH5212(ah); > > =A0 =A0 =A0 =A0 if (keyidx >=3D HAL_DECOMP_MASK_SIZE) > - =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0return AH_FALSE; > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0return HAL_EINVAL; > =A0 =A0 =A0 =A0 OS_REG_WRITE(ah, AR_DCM_A, keyidx); > =A0 =A0 =A0 =A0 OS_REG_WRITE(ah, AR_DCM_D, en ? AR_DCM_D_EN : 0); > =A0 =A0 =A0 =A0 ahp->ah_decompMask[keyidx] =3D en; > > Modified: head/sys/dev/ath/ath_hal/ar5416/ar5416_misc.c > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- head/sys/dev/ath/ath_hal/ar5416/ar5416_misc.c =A0 =A0 =A0 Thu Dec 22 = 13:47:36 2011 =A0 =A0 =A0 =A0(r228799) > +++ head/sys/dev/ath/ath_hal/ar5416/ar5416_misc.c =A0 =A0 =A0 Thu Dec 22 = 14:09:08 2011 =A0 =A0 =A0 =A0(r228800) > @@ -161,7 +161,7 @@ ar5416SetAntennaSwitch(struct ath_hal *a > =A0HAL_BOOL > =A0ar5416SetDecompMask(struct ath_hal *ah, uint16_t keyidx, int en) > =A0{ > - =A0 =A0 =A0 return AH_TRUE; > + =A0 =A0 =A0 return HAL_OK; > =A0} > > =A0/* Setup coverage class */