From owner-svn-src-stable@freebsd.org Thu Mar 15 16:14:58 2018 Return-Path: Delivered-To: svn-src-stable@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 76CBAF5DF01; Thu, 15 Mar 2018 16:14:58 +0000 (UTC) (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net) Received: from pdx.rh.CN85.dnsmgr.net (br1.CN84in.dnsmgr.net [69.59.192.140]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id C523569054; Thu, 15 Mar 2018 16:14:57 +0000 (UTC) (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net) Received: from pdx.rh.CN85.dnsmgr.net (localhost [127.0.0.1]) by pdx.rh.CN85.dnsmgr.net (8.13.3/8.13.3) with ESMTP id w2FGEtg2093806; Thu, 15 Mar 2018 09:14:55 -0700 (PDT) (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net) Received: (from freebsd@localhost) by pdx.rh.CN85.dnsmgr.net (8.13.3/8.13.3/Submit) id w2FGEttu093805; Thu, 15 Mar 2018 09:14:55 -0700 (PDT) (envelope-from freebsd) From: "Rodney W. Grimes" Message-Id: <201803151614.w2FGEttu093805@pdx.rh.CN85.dnsmgr.net> Subject: Re: svn commit: r330972 - stable/11/share/misc In-Reply-To: <1521129735.99081.39.camel@freebsd.org> To: Ian Lepore Date: Thu, 15 Mar 2018 09:14:55 -0700 (PDT) CC: Justin Hibbits , rgrimes@freebsd.org, Andriy Gapon , Eitan Adler , src-committers , svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-11@freebsd.org Reply-To: rgrimes@freebsd.org X-Mailer: ELM [version 2.4ME+ PL121h (25)] MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII X-BeenThere: svn-src-stable@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for all the -stable branches of the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Mar 2018 16:14:58 -0000 > On Thu, 2018-03-15 at 10:52 -0500, Justin Hibbits wrote: > > On Thu, Mar 15, 2018 at 10:46 AM, Ian Lepore wrote: > > > > > > I agree completely with all of this.??It bothers me how many > > > committers > > > have the attitude that handling MFCs is not part of being a > > > committer. > > Never attribute to arrogance that which can adequately be explained > > by > > sheer laziness ;) > > > > - Justin (guilty of marking changes as MFC after, and ignoring them > > for far too long) > > > > Laziness and procrastination I understand -- I own a lovely glass house > in that neighborhood. ?I tend to put off MFCs for way too long then > every few months have to spend a whole weekend catching up. MFC: 1 week (by pool|self) #defaults to self if missing There is already a very nice tracking tool for outstanding MFC's, if we added a bit of smarts in its parser, and created a pool of MFC commiters (Eitan seems to have started one :-)) those who do not want to do there own MFC work could pass the hat. There is the issue that if sizeof(pool) gets to small things shall surely fall off the end. Perhaps at 2 x the timeout on the MFC send a reminder back to the orignal commiter stating the MFC has not happened and is now at 2x timeout? I am guessing, but not certain, eadler is working off a list from svn mergeinfo --show-revs eligible, having that list updated/annoted with "Do note merge: reason" would help the @pool above, and also help with when things are marked MFC, but found later they should not be. Also, I know it has pitfalls and mistakes are gona happen, but I feel a MFC: {never,breaks abi,ugly hack} marking would also help the project with some of this. -- Rod Grimes rgrimes@freebsd.org