From owner-svn-ports-head@freebsd.org Mon Aug 26 14:55:40 2019 Return-Path: Delivered-To: svn-ports-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 85296DDBC5; Mon, 26 Aug 2019 14:55:40 +0000 (UTC) (envelope-from koobs.freebsd@gmail.com) Received: from mail-pf1-x443.google.com (mail-pf1-x443.google.com [IPv6:2607:f8b0:4864:20::443]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46HFRv4Xhgz4WRs; Mon, 26 Aug 2019 14:55:39 +0000 (UTC) (envelope-from koobs.freebsd@gmail.com) Received: by mail-pf1-x443.google.com with SMTP id w16so11958043pfn.7; Mon, 26 Aug 2019 07:55:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:reply-to:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=NVWWA7rbYtin5UiAHlc5rbh6WHmEozURIFeex5VbNbk=; b=qprxMqXLy7YGMqQsVh9y6eIt/2FiZGfoq/J3VMUs0uAmXQSe6bTcy+H27nSZawgitT HyAZ4ewFwDd7WR10Rh04tSA1oYVBUYcHzHoKEcgR+9XjI8YQQ8//bfH8BuKrXXKbr/LA 0lydcyfCj/LR4Adi/8ALmlPOo8NHXwUUM5qvT8D6JuKDETbrOGUCyvEriFwhnr169GJA jAGYJ23RkgxG4lpI/YU33gCYgK1fGRaMuLKMEmp4SSbh6xuVKwbq3pXhN4t2k5ipSZq3 HqstC+NU3PIxLKtYb+jckkDllLXCQ50MX1Zi15jjcH+qilyoamvBy7cCCKnxBZ7FzV4t eaQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:reply-to:subject:to:cc:references:from :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=NVWWA7rbYtin5UiAHlc5rbh6WHmEozURIFeex5VbNbk=; b=GsgniBFjVQV21wmT/N5LZ57126FcXmJZEpI57hLaeBCP5P9DJTRURcGBxgOhBZ69Wx HYyVxuzl/e5fai734+FLzo8LLWyFWo3AjC7mQ6azwtYee/JRM53nRLhBWsRAXbaAlAfv gn+zEpQk0bJUKIJ84/pu8OiK9Yj50Hh1EzlwngHS3NMxajuY1LVVdIOCECZex11L02ao I0ZSQp7ZsevOIme/+05m1SAA4YFuXx9qxn4e+gPlbdFpcYDsa9Op/rJMSKZcCtkMDtqk spL8YHJEK326J1FOmFYQ7yOTqg6QnyQsTzElwe7ni1sqfxGTUb/+ictZOHVfKsq235rt rU8g== X-Gm-Message-State: APjAAAVoEeFej0GT+nCIgIq5ANQpuYURF0G/Sn7GA3tqmDOgnNPZGNq5 BxZEO1LoLaJ1Y5A0A593puuib0NJ X-Google-Smtp-Source: APXvYqyfnGj7HH2bHHNsMb0zPqlnSDAM/0GminOoNnSOrQsRBXnIsTmWeSJFFG9/46o2Wj/0kEOHCg== X-Received: by 2002:a65:56c1:: with SMTP id w1mr16501754pgs.395.1566831337954; Mon, 26 Aug 2019 07:55:37 -0700 (PDT) Received: from [192.168.1.106] (180-150-68-130.b49644.syd.nbn.aussiebb.net. [180.150.68.130]) by smtp.gmail.com with ESMTPSA id d2sm12477705pjg.19.2019.08.26.07.55.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 26 Aug 2019 07:55:37 -0700 (PDT) Sender: Kubilay Kocak Reply-To: koobs@FreeBSD.org Subject: Re: svn commit: r509948 - head/security/gnupg To: Adam Weinberger Cc: Adam Weinberger , ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org References: <201908261441.x7QEfMHM020117@repo.freebsd.org> <478CF5F9-08D4-49C8-B227-C56350958FB3@adamw.org> From: Kubilay Kocak Message-ID: <92d1b586-ed30-2678-3381-d57827c461ac@FreeBSD.org> Date: Tue, 27 Aug 2019 00:55:33 +1000 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:69.0) Gecko/20100101 Thunderbird/69.0 MIME-Version: 1.0 In-Reply-To: <478CF5F9-08D4-49C8-B227-C56350958FB3@adamw.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 46HFRv4Xhgz4WRs X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20161025 header.b=qprxMqXL; dmarc=none; spf=pass (mx1.freebsd.org: domain of koobsfreebsd@gmail.com designates 2607:f8b0:4864:20::443 as permitted sender) smtp.mailfrom=koobsfreebsd@gmail.com X-Spamd-Result: default: False [-4.30 / 15.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; HAS_REPLYTO(0.00)[koobs@FreeBSD.org]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36]; REPLYTO_ADDR_EQ_FROM(0.00)[]; RCPT_COUNT_FIVE(0.00)[5]; RCVD_COUNT_THREE(0.00)[3]; DKIM_TRACE(0.00)[gmail.com:+]; NEURAL_HAM_SHORT(-0.97)[-0.971,0]; FORGED_SENDER(0.30)[koobs@FreeBSD.org,koobsfreebsd@gmail.com]; IP_SCORE(-1.13)[ip: (-0.41), ipnet: 2607:f8b0::/32(-2.87), asn: 15169(-2.33), country: US(-0.05)]; MIME_TRACE(0.00)[0:+]; FREEMAIL_ENVFROM(0.00)[gmail.com]; FROM_NEQ_ENVFROM(0.00)[koobs@FreeBSD.org,koobsfreebsd@gmail.com]; MID_RHS_MATCH_FROM(0.00)[]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20161025]; TAGGED_FROM(0.00)[]; FROM_HAS_DN(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[FreeBSD.org]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[3.4.4.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.b.8.f.7.0.6.2.list.dnswl.org : 127.0.5.0]; RCVD_TLS_ALL(0.00)[] X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 26 Aug 2019 14:55:40 -0000 On 27/08/2019 12:46 am, Adam Weinberger wrote: >> On Aug 26, 2019, at 08:43, Kubilay Kocak wrote: >> >>> On 27/08/2019 12:41 am, Adam Weinberger wrote: >>> Author: adamw >>> Date: Mon Aug 26 14:41:22 2019 >>> New Revision: 509948 >>> URL: https://svnweb.freebsd.org/changeset/ports/509948 >>> Log: >>> gnupg: enable the WKS server >>> Cristoph Lukas asked me why the WKS server was disabled, and I have >>> no idea. It was added r462573, and that commit message and associated >>> bug report don't list why --disable-wks-tools was added. (Folks, >>> please use commit messages for writing, you know, messages.) >>> We've been installing the gpg-wks-server manpage, so this commit >>> enables the WKS server and installs the binary, and bumps PORTREVISION >>> for it. >> >> Seems like a great candidate for an OPTION (enabled by default) ? > > I’m not opposed to it, but I’m also not sure it’s necessary. It brings in no new dependencies, and adds a negligible amount to the disk usage. I know very little about the keyserver; is it something that a significant proportion wouldn’t want installed? I know our FreeBSD users/community can be very picky, and thinking of the clear 'client / server' aspects of gnupg use-cases, it just seemed obvious, or at least like it made sense to provide the option. I know I'd like it, fwiw :) > # Adam > > > — > Adam Weinberger > adamw@adamw.org > https://www.adamw.org > >> >>> While here, sort the plist. >>> Modified: >>> head/security/gnupg/Makefile >>> head/security/gnupg/pkg-plist >>> Modified: head/security/gnupg/Makefile >>> ============================================================================== >>> --- head/security/gnupg/Makefile Mon Aug 26 13:47:28 2019 (r509947) >>> +++ head/security/gnupg/Makefile Mon Aug 26 14:41:22 2019 (r509948) >>> @@ -2,7 +2,7 @@ >>> PORTNAME= gnupg >>> PORTVERSION= 2.2.17 >>> -PORTREVISION= 1 >>> +PORTREVISION= 2 >>> CATEGORIES= security >>> MASTER_SITES= GNUPG >>> @@ -28,8 +28,7 @@ USES= compiler:c11 cpe gmake iconv pkgconfig readline >>> CONFLICTS= gnupg-2.0.* dirmngr-[0-9]* >>> CPE_VENDOR= gnupg >>> -CONFIGURE_ARGS= --disable-ntbtls --disable-wks-tools \ >>> - --enable-gpg-is-gpg2 --enable-symcryptrun >>> +CONFIGURE_ARGS= --disable-ntbtls --enable-gpg-is-gpg2 --enable-symcryptrun >>> GNU_CONFIGURE= yes >>> INFO= gnupg >>> TEST_TARGET= check >>> Modified: head/security/gnupg/pkg-plist >>> ============================================================================== >>> --- head/security/gnupg/pkg-plist Mon Aug 26 13:47:28 2019 (r509947) >>> +++ head/security/gnupg/pkg-plist Mon Aug 26 14:41:22 2019 (r509948) >>> @@ -1,10 +1,11 @@ >>> -bin/gpg-agent >>> bin/dirmngr >>> bin/dirmngr-client >>> +bin/gpg-connect-agent >>> +bin/gpg-agent >>> bin/gpgscm >>> bin/gpgsm >>> bin/gpgtar >>> -bin/gpg-connect-agent >>> +bin/gpg-wks-server >>> bin/kbxutil >>> %%SUID_GPG%%@(,,4555) bin/gpg2 >>> %%NO_SUID_GPG%%bin/gpg2 >>