From owner-freebsd-current@FreeBSD.ORG Fri May 11 13:59:52 2007 Return-Path: X-Original-To: freebsd-current@freebsd.org Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 5670116A406 for ; Fri, 11 May 2007 13:59:52 +0000 (UTC) (envelope-from anderson@freebsd.org) Received: from mh2.centtech.com (moat3.centtech.com [64.129.166.50]) by mx1.freebsd.org (Postfix) with ESMTP id 2B6A313C448 for ; Fri, 11 May 2007 13:59:52 +0000 (UTC) (envelope-from anderson@freebsd.org) Received: from neutrino.centtech.com (neutrino.centtech.com [10.177.171.220]) by mh2.centtech.com (8.13.8/8.13.8) with ESMTP id l4BDxlkN041616; Fri, 11 May 2007 08:59:50 -0500 (CDT) (envelope-from anderson@freebsd.org) Message-ID: <464476D3.3090001@freebsd.org> Date: Fri, 11 May 2007 08:59:47 -0500 From: Eric Anderson User-Agent: Thunderbird 2.0.0.0 (X11/20070420) MIME-Version: 1.0 To: Alexander Leidinger References: <464464BB.3090100@freebsd.org> <20070511152646.g6n5r7k2tcw00ow4@webmail.leidinger.net> In-Reply-To: <20070511152646.g6n5r7k2tcw00ow4@webmail.leidinger.net> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Virus-Scanned: ClamAV 0.88.4/3227/Fri May 11 04:39:25 2007 on mh2.centtech.com X-Virus-Status: Clean X-Spam-Status: No, score=-2.5 required=8.0 tests=AWL,BAYES_00 autolearn=ham version=3.1.6 X-Spam-Checker-Version: SpamAssassin 3.1.6 (2006-10-03) on mh2.centtech.com Cc: freebsd-current@freebsd.org Subject: Re: [PATCH] Fancy rc startup (revisited) X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 May 2007 13:59:52 -0000 On 05/11/07 08:26, Alexander Leidinger wrote: > Quoting Eric Anderson (from Fri, 11 May 2007 > 07:42:35 -0500): > >> About a year ago, I posted[1] a patch to 6-STABLE that added a fancy rc >> startup style similar to linux, with the [OK], [FAILED], etc printouts. >> That patch had serious bit rot and other issues, and so I've now >> revamped it to work on -CURRENT, with a more refined usage, and >> defaults to off. > > I think it is better suited in the rc mailinglist. Yes, I agree, but I wanted a little regular feedback first. I'm not on -rc, so this was a quick first pass. >> I'd rather stay away from a massive bikeshedding, so let me summarize: > > AFAIR the outcome of the last discussion was, that it is ok as long as > the default is to keep the current way of displaying things (which is > what your patch does). So if there are no technical issues with the > patch, it should be ok to commit them. That's correct, and I'm just doing the quick 'peer review' before I beg for a commit. :) >> I'd like to here feedback, and would love to see this go in to the > > Do you have a screenshot? People love screenshots and you may get some > voices like "I want to have this!" from people which fear to install a > patch or from those which don't have time to patch. Here's some kind of bad ones from a qemu session (ignore those calcru errors which I can't seem to get rid of): http://www.googlebit.com/freebsd/patches/rc_fancy_screenshots/ Eric