Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 24 Sep 2019 07:10:51 +0200
From:      Mathieu Arnold <mat@FreeBSD.org>
To:        Dmitri Goutnik <dmgk@FreeBSD.org>
Cc:        ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject:   Re: svn commit: r512675 - head/www/gohugo
Message-ID:  <20190924051051.eazz5myr6f2niwuf@atuin.in.mat.cc>
In-Reply-To: <201909232042.x8NKg2ts076596@repo.freebsd.org>
References:  <201909232042.x8NKg2ts076596@repo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help

--l2xh55lilwg7vt5j
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, Sep 23, 2019 at 08:42:02PM +0000, Dmitri Goutnik wrote:
> Author: dmgk
> Date: Mon Sep 23 20:42:02 2019
> New Revision: 512675
> URL: https://svnweb.freebsd.org/changeset/ports/512675
>=20
> Log:
>   Include bsd.port.pre.mk to get DISTINFO_FILE in scope for the shell com=
mand.
>  =20
>   Reviewed by:	tobik
>   Approved by:	araujo (mentor)
>   Differential Revision:	https://reviews.freebsd.org/D21735
>=20
> Modified:
>   head/www/gohugo/Makefile
>=20
> Modified: head/www/gohugo/Makefile
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D
> --- head/www/gohugo/Makefile	Mon Sep 23 20:41:42 2019	(r512674)
> +++ head/www/gohugo/Makefile	Mon Sep 23 20:42:02 2019	(r512675)
> @@ -106,9 +106,6 @@ GO_BUILDFLAGS=3D	-ldflags=3D"\
>  		-X github.com/gohugoio/hugo/hugolib.CommitHash=3D${COMMIT_ID}" \
>  		${BUILD_TAGS}
> =20
> -SOURCE_DATE_EPOCH_CMD=3D	date -r $$(grep TIMESTAMP ${DISTINFO_FILE} | ${=
SED} -e 's/[^0-9]//g') '+%FT%TZ%z'
> -COMMIT_ID=3D	4aac02d49c2e2bab9f36f0caabbbd9f3cb4715cd
> -
>  OPTIONS_DEFINE=3D		MANPAGES EXTENDED
>  OPTIONS_DEFAULT=3D	MANPAGES EXTENDED
>  OPTIONS_SUB=3D		yes
> @@ -127,6 +124,12 @@ PORTMANS=3D	hugo-config.1 hugo-convert-toJSON.1 hugo=
-con
>  		hugo-new-site.1 hugo-new-theme.1 hugo-new.1 hugo-server.1 \
>  		hugo-version.1 hugo.1
> =20
> +# needed to get DISTINFO_FILE in scope for the shell command evaluation =
by go.mk
> +.include <bsd.port.pre.mk>

No you don't.  make(1) does lazy evaluation, which means it will only
try to figure out the content of a variable when it is used.  When the
targets are run, all variables are available.  You do not need to
include bsd.port.pre.mk.

> +SOURCE_DATE_EPOCH_CMD=3D	date -r $$(grep TIMESTAMP ${DISTINFO_FILE} | ${=
SED} -e 's/[^0-9]//g') '+%FT%TZ%z'
> +COMMIT_ID=3D	4aac02d49c2e2bab9f36f0caabbbd9f3cb4715cd
> +
>  do-build-MANPAGES-on:
>  	@cd ${GO_WRKSRC} && ${GO_WRKDIR_BIN}/${PORTNAME} gen man --dir man/man1/
> =20
> @@ -135,4 +138,4 @@ do-install-MANPAGES-on:
>  	${INSTALL_MAN} ${WRKSRC}/man/man1/$i ${STAGEDIR}/${PREFIX}/man/man1
>  .endfor
> =20
> -.include <bsd.port.mk>
> +.include <bsd.port.post.mk>
>=20

--=20
Mathieu Arnold

--l2xh55lilwg7vt5j
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQKTBAABCgB9FiEEOraXidLtEhBkQLpbOkUW81GDzkgFAl2JpVpfFIAAAAAALgAo
aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNB
QjY5Nzg5RDJFRDEyMTA2NDQwQkE1QjNBNDUxNkYzNTE4M0NFNDgACgkQOkUW81GD
zkha1BAAiawauod/+6GHV+pZ0KxWHVpPoKK3ccbQ1RVAuRgjV+3K3jLnXUv+cR3c
TG+TQWpLrZ5Y1fAauRtZhv+guuat1U5404gNB+SxsZh06h5ffYlHRv2CaXAQnOLJ
uO2fL0TjRx3ELqfBllO5wEtO+eZUPtDdLlcyyj6ZAVJMtybmjNEoxJbpjCPEdahq
Y+T09auRXGv3TxyQL6VTgJ82MvzMCKctipmjpbNccS0t2vTIWuFMuE8c888+RvXK
LJS1pASWvxgCJNR84gKdsMmAv8OhHe/xIXxVHBzbhHw1kGIQ8WCQx0l7lIokdyGD
oJLcjD9NZBZxNGXRXhwm7eoZoHDBVsADd82j4ECjpDbqHUKvj5tQkJmoTJlqg9Mt
XGfNGEFI4+iMywn0uo53GmzOye6kpqwFIHpvnPuRbUIF8OFsKWXe25lNxxeEINkM
HqSYHB2jRBsLO1/dkDI/fBNn6zvrgXJQBXuaVXGsAtliZQHTLoCehUr/OctVDFIG
QY6i+davZmcGGTva1caeugrAe3F3knzJn5qJVR1WRSnZzsIEYH31hpe+YMtjAf0w
LrjQDOxYsB7uBx4CYMe+ZV5A0PSWP5jWEsTKvjrqSAqKWrNUXewb0uy5KSUPgVDq
pp9rlxX/Dm/j03BjaG89Fu0f7ew1QAxN4c4NZfz3ydJbh4L0K9Y=
=Sy8E
-----END PGP SIGNATURE-----

--l2xh55lilwg7vt5j--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20190924051051.eazz5myr6f2niwuf>