From owner-cvs-all Wed Dec 4 9:21:51 2002 Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id F281837B40A for ; Wed, 4 Dec 2002 09:21:44 -0800 (PST) Received: from mail.speakeasy.net (mail16.speakeasy.net [216.254.0.216]) by mx1.FreeBSD.org (Postfix) with ESMTP id 32B8E43ECF for ; Wed, 4 Dec 2002 09:21:43 -0800 (PST) (envelope-from jhb@FreeBSD.org) Received: (qmail 26171 invoked from network); 4 Dec 2002 17:21:47 -0000 Received: from unknown (HELO server.baldwin.cx) ([216.27.160.63]) (envelope-sender ) by mail16.speakeasy.net (qmail-ldap-1.03) with DES-CBC3-SHA encrypted SMTP for ; 4 Dec 2002 17:21:47 -0000 Received: from laptop.baldwin.cx (gw1.twc.weather.com [216.133.140.1]) by server.baldwin.cx (8.12.6/8.12.6) with ESMTP id gB4HLfuH041379; Wed, 4 Dec 2002 12:21:41 -0500 (EST) (envelope-from jhb@FreeBSD.org) Message-ID: X-Mailer: XFMail 1.5.2 on FreeBSD X-Priority: 3 (Normal) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8bit MIME-Version: 1.0 In-Reply-To: <20021204125653.GC31683@sunbay.com> Date: Wed, 04 Dec 2002 12:21:48 -0500 (EST) From: John Baldwin To: Ruslan Ermilov Subject: Re: cvs commit: src/lib/libfetch Makefile Cc: cvs-all@FreeBSD.org, cvs-committers@FreeBSD.org, Jake Burkholder Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On 04-Dec-2002 Ruslan Ermilov wrote: > On Tue, Dec 03, 2002 at 08:34:59PM -0800, Jake Burkholder wrote: >> jake 2002/12/03 20:34:59 PST >> >> Modified files: >> lib/libfetch Makefile >> Log: >> Reduce WARNS level to 3 in the non-crypto case to fix make release on sparc64. >> This may only be turning up now to changes in the cpp predefines for sparc64, >> which may be turning on more strict alignment checking. >> >> Approved by: re >> >> Revision Changes Path >> 1.37 +1 -1 src/lib/libfetch/Makefile >> > Would be more proper then to reduce the WARNS level for sparc64 only: That doesn't motivate the developer to fix their code to not emit warnings as much. :) The last time this came up with people cranking up WARNS on i386 but breaking Alpha the decision was to lower WARNS to the lowest common WARNS level on all archs. > Index: Makefile > =================================================================== > RCS file: /home/ncvs/src/lib/libfetch/Makefile,v > retrieving revision 1.37 > diff -u -r1.37 Makefile > --- Makefile 4 Dec 2002 04:34:59 -0000 1.37 > +++ Makefile 4 Dec 2002 12:55:44 -0000 > @@ -16,7 +16,11 @@ > WARNS?= 2 > .endif > > +.if ${MACHINE_ARCH} == "sparc64" > WARNS?= 3 > +.else > +WARNS?= 5 > +.endif > > SHLIB_MAJOR= 3 > > > Cheers, > -- > Ruslan Ermilov Sysadmin and DBA, > ru@sunbay.com Sunbay Software AG, > ru@FreeBSD.org FreeBSD committer, > +380.652.512.251 Simferopol, Ukraine > > http://www.FreeBSD.org The Power To Serve > http://www.oracle.com Enabling The Information Age -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message