From owner-freebsd-bugs@FreeBSD.ORG  Thu Apr 26 11:00:16 2007
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
X-Original-To: freebsd-bugs@hub.freebsd.org
Delivered-To: freebsd-bugs@hub.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 0889B16A404
	for <freebsd-bugs@hub.freebsd.org>;
	Thu, 26 Apr 2007 11:00:16 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org [69.147.83.40])
	by mx1.freebsd.org (Postfix) with ESMTP id EAE1B13C484
	for <freebsd-bugs@hub.freebsd.org>;
	Thu, 26 Apr 2007 11:00:15 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1])
	by freefall.freebsd.org (8.13.4/8.13.4) with ESMTP id l3QB0FdD025451
	for <freebsd-bugs@freefall.freebsd.org>; Thu, 26 Apr 2007 11:00:15 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.13.4/8.13.4/Submit) id l3QB0F9j025449;
	Thu, 26 Apr 2007 11:00:15 GMT (envelope-from gnats)
Date: Thu, 26 Apr 2007 11:00:15 GMT
Message-Id: <200704261100.l3QB0F9j025449@freefall.freebsd.org>
To: freebsd-bugs@FreeBSD.org
From: Gavin Atkinson <gavin.atkinson@ury.york.ac.uk>
Cc: 
Subject: Re: kern/71792: [vm] [patch] Wrong/missing 'goto' target label in
	contigmalloc1()
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: Gavin Atkinson <gavin.atkinson@ury.york.ac.uk>
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 26 Apr 2007 11:00:16 -0000

The following reply was made to PR kern/71792; it has been noted by GNATS.

From: Gavin Atkinson <gavin.atkinson@ury.york.ac.uk>
To: bug-followup@FreeBSD.org, gemini@geminix.org
Cc:  
Subject: Re: kern/71792: [vm] [patch] Wrong/missing 'goto' target label in
	contigmalloc1()
Date: Thu, 26 Apr 2007 11:54:38 +0100

 I have no idea if this is actually a bug or not, but note that the code
 has changed significantly since this PR was submitted.  In -HEAD, the
 function in question is in src/sys/vm/vm_contig.c
 
 In revision 1.10, the copied/pasted code was factored out, but retained
 the same "goto" semantics that the submitter believes are wrong:
 http://www.freebsd.org/cgi/cvsweb.cgi/src/sys/vm/vm_contig.c.diff?r1=1.9;r2=1.10
 
 Since then, the code has carried on morphing, and the goto in question
 is around line 234 of -HEAD, and is still effectively the same as it
 always was.
 
 This probably needs looking at by a VM expert (alc?) to determine if the
 original submitter's issues with the code are valid.  I do note that
 DragonFlyBVSD seem to have changed this code in
 http://www.dragonflybsd.org/cvsweb/src/sys/vm/vm_contig.c.diff?r1=1.12&r2=1.13 with a commit message indicating that it did indeed fix a possible endless loop.