From owner-freebsd-current@FreeBSD.ORG Wed Feb 11 16:35:45 2004 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id ED13016A4CE for ; Wed, 11 Feb 2004 16:35:45 -0800 (PST) Received: from mailout1.pacific.net.au (mailout1.pacific.net.au [61.8.0.84]) by mx1.FreeBSD.org (Postfix) with ESMTP id 73CC143D39 for ; Wed, 11 Feb 2004 16:35:45 -0800 (PST) (envelope-from bde@zeta.org.au) Received: from mailproxy1.pacific.net.au (mailproxy1.pacific.net.au [61.8.0.86])i1C0ZhLE032643; Thu, 12 Feb 2004 11:35:43 +1100 Received: from gamplex.bde.org (katana.zip.com.au [61.8.7.246]) i1C0Zfi1002732; Thu, 12 Feb 2004 11:35:42 +1100 Date: Thu, 12 Feb 2004 11:35:41 +1100 (EST) From: Bruce Evans X-X-Sender: bde@gamplex.bde.org To: Andre Guibert de Bruet In-Reply-To: <20040210050623.U91658@alpha.siliconlandmark.com> Message-ID: <20040212113128.M83448@gamplex.bde.org> References: <20040208022417.M91658@alpha.siliconlandmark.com> <20040208151037.J91658@alpha.siliconlandmark.com> <20040210050623.U91658@alpha.siliconlandmark.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII cc: current@freebsd.org Subject: Re: make_dev(9) perms for SCSI & SCSI RAID drivers in CURRENT. X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 12 Feb 2004 00:35:46 -0000 On Tue, 10 Feb 2004, Andre Guibert de Bruet wrote: > (Yes, I'm replying to myself... heh) > > On Sun, 8 Feb 2004, Andre Guibert de Bruet wrote: > > > On Mon, 9 Feb 2004, Bruce Evans wrote: > > > > > On Sun, 8 Feb 2004, Andre Guibert de Bruet wrote: > > > ... > > > > Here's a quick illustration of what I'm refering to: > > > > > > > > aac 0640 (octal notation in code) > > > > amr 0600 (implemented as S_IRUSR | S_IWUSR) > > > > asr 0640 (octal notation in code) > > > > ciss 0600 (implemented as S_IRUSR | S_IWUSR) > > > > ida 0600 (implemented as S_IRUSR | S_IWUSR) > > > > iir 0644 (implemented as S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH) > > > > ips 0600 (implemented as S_IRUSR | S_IWUSR) > > > > isp 0600 (octal notation in code) > > > > mly 0600 (implemented as S_IRUSR | S_IWUSR) > > > > > > Most of these actually create control devices, so mode 0600 is correct > > > and group operator is bogus, and mode 0640 is a potental security hole > > > especially with group operator. Group operator is almost always used > > > of course. The data devices are mostly created by the disk mini-layer > > > in RELENG_4 (except RELENG_4 doesn't really have devfs) and by GEOM in > > > -current. > > > > I adjusted and expanded the set of patches that I had to change > > permissions on the control devices so that they also set the GID to wheel. > > The assumption that I am making with these patches is that the drivers > > that are calling make_dev() are creating control devices, as they should > > be letting GEOM create their data devices. Feedback is welcome here as my > > GEOM-fu isn't all that hot... > > > > I have tried to maintain the style used in the drivers themselves and > > fixed the long line in the patch for isp_freebsd.c. > > I've gotten a number of interesting questions and so far no objections. Is > there any chance of getting the patches committed? I have no objections, but will leave it to others (preferably the driver maintainers) to commit the patches. Bruce