From owner-cvs-all  Thu Mar  7  3:24:35 2002
Delivered-To: cvs-all@freebsd.org
Received: from dragon.nuxi.com (trang.nuxi.com [66.92.13.169])
	by hub.freebsd.org (Postfix) with ESMTP
	id E348B37B417; Thu,  7 Mar 2002 03:24:26 -0800 (PST)
Received: (from obrien@localhost)
	by dragon.nuxi.com (8.11.6/8.11.1) id g27BOHg63999;
	Thu, 7 Mar 2002 03:24:17 -0800 (PST)
	(envelope-from obrien)
Date: Thu, 7 Mar 2002 03:20:14 -0800
From: "David O'Brien" <obrien@FreeBSD.org>
To: Will Andrews <will@csociety.org>
Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/usr.bin/rwall rwall.c
Message-ID: <20020307032014.B63863@dragon.nuxi.com>
Reply-To: obrien@FreeBSD.org
References: <200203042027.g24KRc978637@freefall.freebsd.org> <20020307030244.B63484@dragon.nuxi.com> <20020307111707.GK53073@squall.waterspout.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.2.5i
In-Reply-To: <20020307111707.GK53073@squall.waterspout.com>; from will@csociety.org on Thu, Mar 07, 2002 at 06:17:07AM -0500
X-Operating-System: FreeBSD 5.0-CURRENT
Organization: The NUXI BSD group
X-Pgp-Rsa-Fingerprint: B7 4D 3E E9 11 39 5F A3  90 76 5D 69 58 D9 98 7A
X-Pgp-Rsa-Keyid: 1024/34F9F9D5
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
List-ID: <cvs-all.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20cvs-all>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20cvs-all>
X-Loop: FreeBSD.ORG

On Thu, Mar 07, 2002 at 06:17:07AM -0500, Will Andrews wrote:
> On Thu, Mar 07, 2002 at 03:02:44AM -0800, David O'Brien wrote:
> > -       if ((fd = mkstemp(tmpname)) == -1 || !(fp = fdopen(fd, "r+")))
> > +       fd = mkstemp(tmpname);
> > +       fp = fdopen(fd, "r+");
> > +       if (fd == -1 || !fp)
> > 
> > Why did you need to do such code restructuring?
> 
> In my opinion, the above change makes the code clearer.  The
> previous construct obfuscates the logic.

1. that is not sufficient reason to arbitrarily change working code.
2. please review the C idiom of short-circuit evaluation.

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message