From owner-cvs-all@FreeBSD.ORG Wed Sep 27 06:38:55 2006 Return-Path: X-Original-To: cvs-all@FreeBSD.org Delivered-To: cvs-all@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C2C2316A407; Wed, 27 Sep 2006 06:38:55 +0000 (UTC) (envelope-from anholt@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id BE38843D46; Wed, 27 Sep 2006 06:38:54 +0000 (GMT) (envelope-from anholt@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k8R6csED044992; Wed, 27 Sep 2006 06:38:54 GMT (envelope-from anholt@repoman.freebsd.org) Received: (from anholt@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k8R6csJ0044991; Wed, 27 Sep 2006 06:38:54 GMT (envelope-from anholt) Message-Id: <200609270638.k8R6csJ0044991@repoman.freebsd.org> From: Eric Anholt Date: Wed, 27 Sep 2006 06:38:54 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/pci agp_i810.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 27 Sep 2006 06:38:55 -0000 anholt 2006-09-27 06:38:54 UTC FreeBSD src repository Modified files: sys/pci agp_i810.c Log: Add support for 945G/GM AGP chipsets. The key problem was that the aperture size detection using the MSAC bit doesn't work -- the bit appears to be set even when it shouldn't be. Linux takes a different approach, testing for a bit of the GMADR (PCIR_BAR(2)) being set. However, as I don't think that's a safe way to test aperture size, we just allocate the resource and check its size. This also pointed out that agp_generic_attach hadn't been allocating our aperture resource, which may have caused problems in some cases. Also corrected is a minor copy-and-pasteo in an error case. PR: kern/103079 Submitted by: mnag Tested on: i945GM, i915GM MFC after: 2 weeks Revision Changes Path 1.39 +29 -13 src/sys/pci/agp_i810.c