From owner-freebsd-current Sun Feb 15 00:35:35 1998 Return-Path: Received: (from majordom@localhost) by hub.freebsd.org (8.8.8/8.8.8) id AAA23091 for freebsd-current-outgoing; Sun, 15 Feb 1998 00:35:35 -0800 (PST) (envelope-from owner-freebsd-current@FreeBSD.ORG) Received: from time.cdrom.com (root@time.cdrom.com [204.216.27.226]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id AAA23081 for ; Sun, 15 Feb 1998 00:35:33 -0800 (PST) (envelope-from jkh@time.cdrom.com) Received: from time.cdrom.com (jkh@localhost.cdrom.com [127.0.0.1]) by time.cdrom.com (8.8.8/8.6.9) with ESMTP id AAA20317; Sun, 15 Feb 1998 00:32:00 -0800 (PST) To: Greg Lehey cc: Chris Csanady , freebsd-current@FreeBSD.ORG Subject: Re: CCD missing spl() call.. In-reply-to: Your message of "Sun, 15 Feb 1998 15:43:50 +1030." <19980215154350.44866@freebie.lemis.com> Date: Sun, 15 Feb 1998 00:32:00 -0800 Message-ID: <20313.887531520@time.cdrom.com> From: "Jordan K. Hubbard" Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG > OK. The first one (off by 1) makes sense, but the second one (splbio) > was there from the start. What sources are you comparing with? Actually, there should be no splbio() in the interrupt routine and now that I've actually gotten the grit out of my eyes and looked at it again, I see that the whole addition was bogus for a variety of reasons: 1. There was no corresponding splx(s), even if the splbio() had been correct. 2. You don't need to raise the SPL level in the interrupt routine. 3. The tabs were smashed, violating the Bruce exclusion filter rules. :-) The off-by-one stuff was OK and has been committed, but more care will have to be taken with any further "OpenBSD improvements" if they're going to make the grade. :-) Jordan To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message