From owner-svn-src-all@freebsd.org Wed Jul 29 16:48:30 2015 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 24BCF9AC887; Wed, 29 Jul 2015 16:48:30 +0000 (UTC) (envelope-from gnn@neville-neil.com) Received: from smtp.hungerhost.com (smtp.hungerhost.com [216.38.53.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id EFF586B3; Wed, 29 Jul 2015 16:48:29 +0000 (UTC) (envelope-from gnn@neville-neil.com) Received: from pool-108-54-164-204.nycmny.fios.verizon.net ([108.54.164.204]:51609 helo=[192.168.1.11]) by vps.hungerhost.com with esmtpsa (TLSv1:DHE-RSA-AES256-SHA:256) (Exim 4.85) (envelope-from ) id 1ZKUWo-0000vW-Pe; Wed, 29 Jul 2015 12:48:26 -0400 From: "George Neville-Neil" To: "Gleb Smirnoff" Cc: "Ermal =?utf-8?q?Lu=C3=A7i?=" , "Olivier =?utf-8?q?Cochard-Labb=C3=A9?=" , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r285051 - head/sys/netinet Date: Wed, 29 Jul 2015 12:48:15 -0400 Message-ID: In-Reply-To: <20150729150544.GM97401@FreeBSD.org> References: <201507021810.t62IAgCc003272@repo.freebsd.org> <20150728124220.GW72729@FreeBSD.org> <20150729150544.GM97401@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-Mailer: MailMate (1.9.2r5107) X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - vps.hungerhost.com X-AntiAbuse: Original Domain - freebsd.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - neville-neil.com X-Get-Message-Sender-Via: vps.hungerhost.com: authenticated_id: gnn@neville-neil.com X-Source: X-Source-Args: X-Source-Dir: X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 29 Jul 2015 16:48:30 -0000 On 29 Jul 2015, at 11:05, Gleb Smirnoff wrote: > Ermal, > > On Wed, Jul 29, 2015 at 03:00:59PM +0200, Ermal Luçi wrote: > E> > E> @@ -934,6 +950,7 @@ ip_forward(struct mbuf *m, int srcrt) > E> > E> */ > E> > E> if (!srcrt && ia == NULL) { > E> > E> icmp_error(m, ICMP_UNREACH, ICMP_UNREACH_HOST, 0, > 0); > E> > E> + RO_RTFREE(&ro); > E> > E> return; > E> > E> } > E> > > E> > Here the ifa reference is leaked upon return. > E> > > E> > > E> Gleb, > E> > E> the improvement on the ifa_ref not needed is something to look at > but the > E> ifa_ref here is not lost since ia == NULL, no? > E> Maybe i am missing something else. > > Sure you are right. Mea culpa. > > E> Also can we put this on a review? > > It is possible. Let's just wait for Olivier to return and ask him to > do a benchmark :) > Olivier isnt' the only one that can do a benchmark. I can chuck this up in the Sentex lab, that's what it's for. Give me a brief outline and I'll code something up in Conductor. Best, George