From nobody Sat Sep 3 10:22:21 2022 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4MKW720ZKfz4bw3w; Sat, 3 Sep 2022 10:22:22 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4MKW7205pKz41N8; Sat, 3 Sep 2022 10:22:22 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1662200542; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=XVETdZqTFe6WNfmRCtL83IbnKNdxFbkuvAQACNagpmc=; b=xTSzzYZ2Epq0Ka8SpvX1a2L3a7SuovV6T9+u3W0ZZWOQTlztc/kttVyZH94808W5woxDlV e+XWi4WE/cmIer9pLoxfEmD3E7JYA26X4P3ShQQVnUhpkqP48mvPvD1W7jI4utqCXwkqPw f6/ajySSI6kX8e1EzPtiHJsCDVozj9SB8kigr9jL5OrsCIqb5CxaUzDydJzolE8cAiXIHF sjdQFlDZgqNgnrWKvUo7PCbmUCdbghQ6tgRRkC8S4qD/am558mtDZ7Yr9kdgNeQ3lyKomu fwVEGoEo+IpYfjFEuvukgOHc0Az73vXPMTTVEDl0btvGhCPxb8cI0yeFghbSTA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4MKW716FjHz16n1; Sat, 3 Sep 2022 10:22:21 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 283AML4p072999; Sat, 3 Sep 2022 10:22:21 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 283AMLE6072998; Sat, 3 Sep 2022 10:22:21 GMT (envelope-from git) Date: Sat, 3 Sep 2022 10:22:21 GMT Message-Id: <202209031022.283AMLE6072998@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Hans Petter Selasky Subject: git: 3a3357995908 - stable/13 - usb(4): Quirk for non-compliant USB devices. List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: hselasky X-Git-Repository: src X-Git-Refname: refs/heads/stable/13 X-Git-Reftype: branch X-Git-Commit: 3a3357995908ed5f51af5be43fa5196300ab5cb3 Auto-Submitted: auto-generated ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1662200542; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=XVETdZqTFe6WNfmRCtL83IbnKNdxFbkuvAQACNagpmc=; b=bGchXcawzBfirONCKiGyPzVXhuBioADzKditaLJ+q2soBTTYugi3Dbw/ISvWFVRE6GDqTK 0hUE8TUatVijVpXZAhRBFLTFoVPvWr5eO23fnb5YHmYT8wps9y7F4F1mUFiP2uGFSKhyLj 4Cby/sl8u5uhw8fiR2dAcBWZfm8o3EBH8m+4gixz9naKOymsc7BN0RSbfvjyXkPNW1S2lj y4gMtw5Y9djeZqHKBMNZ9AUORikW1I7URhZ/rPJmK+SByFxirDkBsu3+vsVJJjOiKfZ2Rq ZSvJhUQumAnJg18M9H3X+ENH/UYu36dprLtu4qt1t+7kAD6et2vjNpca9Sbw5A== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1662200542; a=rsa-sha256; cv=none; b=ZFSyB5Xmlk3r/YiINkt2pJOlHK0voH98E7+W5DuCAWCvOlgmZsf1FNTcB33wGkIHXOrdA1 H44D4QWBNuZiU6+P4qLtVZY1VyUoSoAkOOpPf8KcLQsJ2fk8L/9BpY4NjXnYk6vZ4+hytF 5NWBxfHu8zEs08CfDv19A+O5DsEbrtm1jmA1Im4OLfpbbDRmp3ZYZ4D1LDt4Y4UquteuH0 R7idy1V2/wUz8nP0C9ehKwcuCKrRWkKZzjj9OmDcgq4oAFUjT9HkMhZPJLARSPj7uPDb47 wKziB6T6ehuK7ohriPu1t4u0hV4xUVYZr8NpIIIK3rud7dAgFRJPfK9Bl+3AHQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N The branch stable/13 has been updated by hselasky: URL: https://cgit.FreeBSD.org/src/commit/?id=3a3357995908ed5f51af5be43fa5196300ab5cb3 commit 3a3357995908ed5f51af5be43fa5196300ab5cb3 Author: Hans Petter Selasky AuthorDate: 2022-08-27 06:50:51 +0000 Commit: Hans Petter Selasky CommitDate: 2022-09-03 10:22:07 +0000 usb(4): Quirk for non-compliant USB devices. Some non-compliant USB devices do not implement the clear endpoint halt feature. Silently ignore such failures, when they at least responded correctly passing up a valid STALL PID packet. Tested by: Doug Ambrisko Sponsored by: NVIDIA Networking (cherry picked from commit 4e2d8cd3e29bc885567f61ff358f8c9459d621ce) --- sys/dev/usb/usb_request.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/sys/dev/usb/usb_request.c b/sys/dev/usb/usb_request.c index a1781f3589a4..c5b370ccd31a 100644 --- a/sys/dev/usb/usb_request.c +++ b/sys/dev/usb/usb_request.c @@ -313,6 +313,16 @@ tr_setup: */ if (usb_no_cs_fail) goto tr_transferred; + + /* + * Some non-compliant USB devices do not implement the + * clear endpoint halt feature. Silently ignore such + * devices, when they at least respond correctly + * passing up a valid STALL PID packet. + */ + if (error == USB_ERR_STALLED) + goto tr_transferred; + if (udev->clear_stall_errors == USB_CS_RESET_LIMIT) goto tr_setup;