From owner-svn-src-all@freebsd.org Wed Nov 2 07:53:12 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id E9EE8C2AAB5; Wed, 2 Nov 2016 07:53:12 +0000 (UTC) (envelope-from dim@FreeBSD.org) Received: from tensor.andric.com (tensor.andric.com [IPv6:2001:7b8:3a7:1:2d0:b7ff:fea0:8c26]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "tensor.andric.com", Issuer "COMODO RSA Domain Validation Secure Server CA" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 8829B1F4E; Wed, 2 Nov 2016 07:53:12 +0000 (UTC) (envelope-from dim@FreeBSD.org) Received: from [IPv6:2001:7b8:3a7::d184:fcf6:484f:1394] (unknown [IPv6:2001:7b8:3a7:0:d184:fcf6:484f:1394]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by tensor.andric.com (Postfix) with ESMTPSA id D766A12C5C; Wed, 2 Nov 2016 08:53:08 +0100 (CET) Content-Type: multipart/signed; boundary="Apple-Mail=_5010B624-4795-4995-8532-CD3F6C39A9D9"; protocol="application/pgp-signature"; micalg=pgp-sha1 Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\)) Subject: Re: svn commit: r308181 - in head: . share/mk From: Dimitry Andric In-Reply-To: <69A64340-FE51-4AF0-9905-B46220D041E9@FreeBSD.org> Date: Wed, 2 Nov 2016 08:53:05 +0100 Cc: src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org, Ed Maste , Jonathan Anderson Message-Id: <459BD98A-4788-497E-B2D5-5EC20C5B9EE8@FreeBSD.org> References: <201611012127.uA1LRg0B045900@repo.freebsd.org> <46715A69-03C5-404F-B133-C8FE89D59A9B@FreeBSD.org> <69A64340-FE51-4AF0-9905-B46220D041E9@FreeBSD.org> To: Antoine Brodin X-Mailer: Apple Mail (2.3124) X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 Nov 2016 07:53:13 -0000 --Apple-Mail=_5010B624-4795-4995-8532-CD3F6C39A9D9 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii On 02 Nov 2016, at 08:25, Jonathan Anderson = wrote: >=20 > On 1 Nov 2016, at 21:10, Dimitry Andric wrote: >=20 >> Please note, I reverted r307823 (which changed the suffixes from .bco >> and .llo to .bc and .ll) in r308003, since it caused a number of = ports >> failures. These ports were already using .ll as a suffix for C++ lex >> scripts. >=20 > The changes to bsd.suffixes-posix.mk (included by sys.mk) would have = affected anything compiled with bmake, and indeed, I'd imagine that = adding a .c->.ll rule alongside .c->.o could cause problems with C++ lex = rules. In fact, part of brooks' original motivation for introducing .llo = suffixes was to avoid name conflicts (although conflicts with program IR = like we're introducing in this commit). The changes in this commit = should only be picked up by things that explicit include = bsd.{lib,prog}.mk, however, and they also have slightly more esoteric = names (e.g., progname.full.ll) that are less likely to cause a conflict. = Perhaps I ought to have done an exp-run, but I suspect that this commit = will cause much less / no fallout. I don't suppose you have a list of = the ports that failed after your r307823 change so that I could do spot = checks? Hi Antoine, you pointed me at some of these port failures due to the .ll change, do you still have a list of them? -Dimitry --Apple-Mail=_5010B624-4795-4995-8532-CD3F6C39A9D9 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0.30 iEYEARECAAYFAlgZm2UACgkQsF6jCi4glqPF/wCghI2Bzv/tDpoLiWG6MUOss4/t qFQAn0tj6GxNxmdXvMVwezZJQBZdfKTO =drqb -----END PGP SIGNATURE----- --Apple-Mail=_5010B624-4795-4995-8532-CD3F6C39A9D9--